Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2873233002: Linux native notifications: Localize settings button. (Closed)

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 7 months ago
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux native notifications: Localize settings button. BUG=676220 Review-Url: https://codereview.chromium.org/2873233002 Cr-Commit-Position: refs/heads/master@{#470538} Committed: https://chromium.googlesource.com/chromium/src/+/bb3a8148c6f47151d82b7b9e490d8157d5e1fa6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/notifications/notification_platform_bridge_linux.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Lei Zhang
3 years, 7 months ago (2017-05-10 02:47:39 UTC) #2
Tom (Use chromium acct)
lgtm
3 years, 7 months ago (2017-05-10 06:06:30 UTC) #3
Peter Beverloo
lgtm
3 years, 7 months ago (2017-05-10 11:19:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873233002/1
3 years, 7 months ago (2017-05-10 11:19:50 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 12:25:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bb3a8148c6f47151d82b7b9e490d...

Powered by Google App Engine
This is Rietveld 408576698