Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 287323002: Fix lint issues with AndroidScrollIntegrationTest.java. (Closed)

Created:
6 years, 7 months ago by Sungmann Cho
Modified:
6 years, 7 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix lint issues with AndroidScrollIntegrationTest.java. Currently, the lint warns against using the implicit default locale in String.format(). We should use the explicit locale instead of it. BUG=327768 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271295

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Sungmann Cho
Please take a look. Thanks!
6 years, 7 months ago (2014-05-18 06:11:50 UTC) #1
boliu
lgtm
6 years, 7 months ago (2014-05-18 06:14:07 UTC) #2
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-05-18 06:15:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/287323002/1
6 years, 7 months ago (2014-05-18 06:15:25 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-18 07:57:57 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-18 08:59:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/28230)
6 years, 7 months ago (2014-05-18 08:59:49 UTC) #7
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-05-18 09:17:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/287323002/1
6 years, 7 months ago (2014-05-18 09:17:29 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-18 14:19:08 UTC) #10
Message was sent while issue was closed.
Change committed as 271295

Powered by Google App Engine
This is Rietveld 408576698