Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java

Issue 287323002: Fix lint issues with AndroidScrollIntegrationTest.java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java
index 9c522a5280978c9dfb1b0a402d858432419c8be3..5640ea1f10065a174d8b877a77b1e9cadee5f9e1 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java
@@ -19,6 +19,7 @@ import org.chromium.content.browser.test.util.CallbackHelper;
import org.chromium.content_public.browser.GestureStateListener;
import org.chromium.ui.gfx.DeviceDisplayInfo;
+import java.util.Locale;
import java.util.concurrent.Callable;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.atomic.AtomicBoolean;
@@ -830,9 +831,11 @@ public class AndroidScrollIntegrationTest extends AwTestBase {
int newContentHeightApproximation =
(int) Math.ceil(awContents.computeVerticalScrollRange() / newScale);
- assertTrue(String.format("Scale range should increase after zoom (%f) > (%f)",
+ assertTrue(String.format(Locale.ENGLISH,
+ "Scale range should increase after zoom (%f) > (%f)",
newScale, oldScale), newScale > oldScale);
- assertTrue(String.format("Scroll range should increase after zoom (%d) > (%d)",
+ assertTrue(String.format(Locale.ENGLISH,
+ "Scroll range should increase after zoom (%d) > (%d)",
newScrollRange, oldScrollRange), newScrollRange > oldScrollRange);
assertEquals(awContents.getContentHeightCss(), oldContentHeightApproximation);
assertEquals(awContents.getContentHeightCss(), newContentHeightApproximation);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698