third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 2873213003: Move WebFrame to use WebLocalFrameBase instead of WebLocalFrameImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2873213003: Move WebFrame to use WebLocalFrameBase instead of WebLocalFrameImpl. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 32d805f9a5ef089148ec60050f926c431ad18fe0..bdb5e905ebe22fc97586a89fccea4b61545e71e1 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -1629,6 +1629,8 @@ DEFINE_TRACE(WebLocalFrameImpl) {

visitor->Trace(print_context_);

visitor->Trace(context_menu_node_);

visitor->Trace(text_checker_client_);

+ WebLocalFrameBase::Trace(visitor);

+ // TODO(slangley): Call this from WebLocalFrameBase, once WebFrame is in core.

WebFrame::TraceFrames(visitor, this);

haraken 2017/05/11 01:01:27 Why can't we move this to WebLocalFrameBase's DEFI

}

« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.h ('k') | no next file » | no next file with comments »