Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2873213003: Move WebFrame to use WebLocalFrameBase instead of WebLocalFrameImpl. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1611 matching lines...) Expand 10 before | Expand all | Expand 10 after
1622 } 1622 }
1623 1623
1624 DEFINE_TRACE(WebLocalFrameImpl) { 1624 DEFINE_TRACE(WebLocalFrameImpl) {
1625 visitor->Trace(local_frame_client_impl_); 1625 visitor->Trace(local_frame_client_impl_);
1626 visitor->Trace(frame_); 1626 visitor->Trace(frame_);
1627 visitor->Trace(dev_tools_agent_); 1627 visitor->Trace(dev_tools_agent_);
1628 visitor->Trace(text_finder_); 1628 visitor->Trace(text_finder_);
1629 visitor->Trace(print_context_); 1629 visitor->Trace(print_context_);
1630 visitor->Trace(context_menu_node_); 1630 visitor->Trace(context_menu_node_);
1631 visitor->Trace(text_checker_client_); 1631 visitor->Trace(text_checker_client_);
1632 WebLocalFrameBase::Trace(visitor);
1633 // TODO(slangley): Call this from WebLocalFrameBase, once WebFrame is in core.
1632 WebFrame::TraceFrames(visitor, this); 1634 WebFrame::TraceFrames(visitor, this);
haraken 2017/05/11 01:01:27 Why can't we move this to WebLocalFrameBase's DEFI
1633 } 1635 }
1634 1636
1635 void WebLocalFrameImpl::SetCoreFrame(LocalFrame* frame) { 1637 void WebLocalFrameImpl::SetCoreFrame(LocalFrame* frame) {
1636 frame_ = frame; 1638 frame_ = frame;
1637 } 1639 }
1638 1640
1639 void WebLocalFrameImpl::InitializeCoreFrame(Page& page, 1641 void WebLocalFrameImpl::InitializeCoreFrame(Page& page,
1640 FrameOwner* owner, 1642 FrameOwner* owner,
1641 const AtomicString& name) { 1643 const AtomicString& name) {
1642 SetCoreFrame(LocalFrame::Create(local_frame_client_impl_.Get(), page, owner, 1644 SetCoreFrame(LocalFrame::Create(local_frame_client_impl_.Get(), page, owner,
(...skipping 933 matching lines...) Expand 10 before | Expand all | Expand 10 after
2576 TextCheckerClient& WebLocalFrameImpl::GetTextCheckerClient() const { 2578 TextCheckerClient& WebLocalFrameImpl::GetTextCheckerClient() const {
2577 return *text_checker_client_; 2579 return *text_checker_client_;
2578 } 2580 }
2579 2581
2580 void WebLocalFrameImpl::SetTextCheckClient( 2582 void WebLocalFrameImpl::SetTextCheckClient(
2581 WebTextCheckClient* text_check_client) { 2583 WebTextCheckClient* text_check_client) {
2582 text_check_client_ = text_check_client; 2584 text_check_client_ = text_check_client;
2583 } 2585 }
2584 2586
2585 } // namespace blink 2587 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698