Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2873213002: Add PlatformFrameView class. (Closed)

Created:
3 years, 7 months ago by joelhockey
Modified:
3 years, 7 months ago
Reviewers:
haraken, dcheng
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, krit, Eric Willigers, fmalita+watch_chromium.org, fs, gyuyoung2, kinuko+watch, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add PlatformFrameView class. PlatformFrameView is used in PlatformChromeClient as the platform base class for core/frame/FrameView. This removes a reference to FrameViewBase which is being deleted in http://crrev.com/2855523002. BUG=637460 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2873213002 Cr-Commit-Position: refs/heads/master@{#470849} Committed: https://chromium.googlesource.com/chromium/src/+/d3fb9e2435e2c3015314496c2afa5bf64c4ace56

Patch Set 1 #

Total comments: 2

Patch Set 2 : update comments #

Patch Set 3 : rebase #

Patch Set 4 : make gc #

Patch Set 5 : back to no gc #

Patch Set 6 : #include PlatformFrameView inside platform.dll #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -32 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 3 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameViewTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/AutoscrollController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/PageAnimator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/PlatformChromeClient.h View 1 2 3 4 5 2 chunks +3 lines, -4 lines 0 comments Download
A third_party/WebKit/Source/platform/PlatformFrameView.h View 1 4 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +11 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlayAgent.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 50 (33 generated)
joelhockey
3 years, 7 months ago (2017-05-10 01:32:01 UTC) #3
haraken
LGTM https://codereview.chromium.org/2873213002/diff/1/third_party/WebKit/Source/platform/PlatformFrameView.h File third_party/WebKit/Source/platform/PlatformFrameView.h (right): https://codereview.chromium.org/2873213002/diff/1/third_party/WebKit/Source/platform/PlatformFrameView.h#newcode12 third_party/WebKit/Source/platform/PlatformFrameView.h:12: // PlatformFrameView is used in PlatformChromeClient as the ...
3 years, 7 months ago (2017-05-10 01:36:15 UTC) #4
joelhockey
https://codereview.chromium.org/2873213002/diff/1/third_party/WebKit/Source/platform/PlatformFrameView.h File third_party/WebKit/Source/platform/PlatformFrameView.h (right): https://codereview.chromium.org/2873213002/diff/1/third_party/WebKit/Source/platform/PlatformFrameView.h#newcode12 third_party/WebKit/Source/platform/PlatformFrameView.h:12: // PlatformFrameView is used in PlatformChromeClient as the platform ...
3 years, 7 months ago (2017-05-10 01:42:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873213002/20001
3 years, 7 months ago (2017-05-10 01:42:51 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/407394)
3 years, 7 months ago (2017-05-10 02:48:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873213002/100001
3 years, 7 months ago (2017-05-10 09:14:25 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/449894)
3 years, 7 months ago (2017-05-10 12:10:01 UTC) #29
dcheng
LGTM
3 years, 7 months ago (2017-05-10 17:31:37 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873213002/100001
3 years, 7 months ago (2017-05-10 17:39:18 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450534)
3 years, 7 months ago (2017-05-10 20:10:25 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873213002/100001
3 years, 7 months ago (2017-05-10 20:51:13 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450838)
3 years, 7 months ago (2017-05-11 00:39:03 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873213002/100001
3 years, 7 months ago (2017-05-11 00:40:59 UTC) #40
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451199)
3 years, 7 months ago (2017-05-11 03:50:09 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873213002/100001
3 years, 7 months ago (2017-05-11 03:55:36 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873213002/100001
3 years, 7 months ago (2017-05-11 04:16:21 UTC) #47
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 06:39:52 UTC) #50
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/d3fb9e2435e2c3015314496c2afa...

Powered by Google App Engine
This is Rietveld 408576698