Add public_deps for //ios/chrome/browser/tabs and //ios/chrome/browser/ui/tabs

Add public_deps for //ios/chrome/browser/tabs, //ios/chrome/browser/ui/tabs and //ios/web


//ios/chrome/browser/tabs details:
tab.h includes files from these targets, therefore they are part of //ios/chrome/browser/tabs public interface.

Example error:
In file included from ../../ios/chrome/browser/ui/stack_view/stack_view_egtest.mm:13:
In file included from ../../ios/chrome/browser/tabs/tab.h:17:
In file included from ../../ios/web/public/web_state/ui/crw_web_delegate.h:15:
In file included from ../../ios/web/public/ssl_status.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:71:10: fatal error: 'openssl/is_boringssl.h' file not found


//ios/chrome/browser/ui/tabs details:
tab_view.h includes headers from these targets, thus they are part of //ios/chrome/browser/ui/tabs public interface.

Example error:
In file included from ../../ios/chrome/browser/ui/tabs/tab_strip_egtest.mm:9:
In file included from ../../ios/chrome/browser/ui/tabs/tab_view.h:11:
In file included from ../../ios/chrome/browser/tabs/tab.h:17:
In file included from ../../ios/web/public/web_state/ui/crw_web_delegate.h:15:
In file included from ../../ios/web/public/ssl_status.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:71:10: fatal error: 'openssl/is_boringssl.h' file not found


//ios/web:web_arc details:
ssl_status.h includes headers from net, thus they are part of //ios/web:web_arc public interface.

Example error:
    In file included from ../../ios/chrome/browser/ui/payments/payment_request_manager.mm:31:
    In file included from ../../ios/web/public/ssl_status.h:12:
    In file included from ../../net/cert/x509_certificate.h:25:
    ../../third_party/boringssl/src/include/openssl/base.h:71:10: fatal error: 'openssl/is_boringssl.h' file not found


BUG=none

Review-Url: https://codereview.chromium.org/2873203002
Cr-Commit-Position: refs/heads/master@{#471037}
Committed: https://chromium.googlesource.com/chromium/src/+/2791788c6454704a4d6f8f6a917a3017b20f966a

[mattm, 2017-05-10 01:26:52]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 01:27:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2017-05-10 01:33:42]

mattm@chromium.org changed reviewers:
+ rohitrao@chromium.org

[commit-bot: I haz the power, 2017-05-10 03:30:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 03:30:07]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has
not started yet; builder either lacks capacity or does not exist (misspelled?))
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[rohitrao (ping after 24h), 2017-05-10 12:55:48]

rohitrao@chromium.org changed reviewers:
+ sdefresne@chromium.org

[rohitrao (ping after 24h), 2017-05-10 12:55:49]

+sdefresne because I've never been clear on the rules for public_deps.

[sdefresne, 2017-05-10 14:16:31]

On 2017/05/10 12:55:49, rohitrao (ping after 24h) wrote:
> +sdefresne because I've never been clear on the rules for public_deps.

In src/ios, we try to limit the use of public_deps to either:
- propagate public_configs
- hide intermediate targets (for example //ios/web & //ios/web:web_arc).

This mean for example that if a target include a file from src/base in its
header, we generally do not put //base in the target public_deps (even though
base is technically part of the target public interface).

Regarding this CL, there is a need to propagate a public_configs from
//third_party/boringssl to get the correct include path. As you can see from the
#include trace, the file is included by //ios/web public header, so the target
//net should be added to //ios/web public_deps. Regarding tab.h however, I would
prefer if we moved the include of crw_web_delegate.h into the private API of
tab.h, but if we don't we need to add //ios/web to //ios/chrome/browser/tabs
public_deps.

So my recommendation are to limit the CL to the following changes:
1. add //net to //ios/web public_deps
2. add //ios/web to //ios/chrome/browser/tabs public_deps

[mattm, 2017-05-10 17:27:34]

Description was changed from

==========
Add public_deps for //ios/chrome/browser/tabs and //ios/chrome/browser/ui/tabs


//ios/chrome/browser/tabs details:
tab.h includes files from these targets, therefore they are part of
//ios/chrome/browser/tabs public interface.

Example error:
In file included from
../../ios/chrome/browser/ui/stack_view/stack_view_egtest.mm:13:
In file included from ../../ios/chrome/browser/tabs/tab.h:17:
In file included from ../../ios/web/public/web_state/ui/crw_web_delegate.h:15:
In file included from ../../ios/web/public/ssl_status.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:71:10: fatal error:
'openssl/is_boringssl.h' file not found
         ^~~~~~~~~~~~~~~~~~~~~~~~


//ios/chrome/browser/ui/tabs details:
tab_view.h includes headers from these targets, thus they are part of
//ios/chrome/browser/ui/tabs public interface.

Example error:

In file included from ../../ios/chrome/browser/ui/tabs/tab_strip_egtest.mm:9:
In file included from ../../ios/chrome/browser/ui/tabs/tab_view.h:11:
In file included from ../../ios/chrome/browser/tabs/tab.h:17:
In file included from ../../ios/web/public/web_state/ui/crw_web_delegate.h:15:
In file included from ../../ios/web/public/ssl_status.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:71:10: fatal error:
'openssl/is_boringssl.h' file not found
         ^~~~~~~~~~~~~~~~~~~~~~~~


BUG=none
==========

to

==========
Add public_deps for //ios/chrome/browser/tabs, //ios/chrome/browser/ui/tabs and
//ios/web


//ios/chrome/browser/tabs details:
tab.h includes files from these targets, therefore they are part of
//ios/chrome/browser/tabs public interface.

Example error:
In file included from
../../ios/chrome/browser/ui/stack_view/stack_view_egtest.mm:13:
In file included from ../../ios/chrome/browser/tabs/tab.h:17:
In file included from ../../ios/web/public/web_state/ui/crw_web_delegate.h:15:
In file included from ../../ios/web/public/ssl_status.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:71:10: fatal error:
'openssl/is_boringssl.h' file not found


//ios/chrome/browser/ui/tabs details:
tab_view.h includes headers from these targets, thus they are part of
//ios/chrome/browser/ui/tabs public interface.

Example error:
In file included from ../../ios/chrome/browser/ui/tabs/tab_strip_egtest.mm:9:
In file included from ../../ios/chrome/browser/ui/tabs/tab_view.h:11:
In file included from ../../ios/chrome/browser/tabs/tab.h:17:
In file included from ../../ios/web/public/web_state/ui/crw_web_delegate.h:15:
In file included from ../../ios/web/public/ssl_status.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:71:10: fatal error:
'openssl/is_boringssl.h' file not found


//ios/web:web_arc details:
ssl_status.h includes headers from net, thus they are part of //ios/web:web_arc
public interface.

Example error:
    In file included from
../../ios/chrome/browser/ui/payments/payment_request_manager.mm:31:
    In file included from ../../ios/web/public/ssl_status.h:12:
    In file included from ../../net/cert/x509_certificate.h:25:
    ../../third_party/boringssl/src/include/openssl/base.h:71:10: fatal error:
'openssl/is_boringssl.h' file not found


BUG=none
==========

[mattm, 2017-05-10 17:30:48]

On 2017/05/10 14:16:31, sdefresne wrote:
> On 2017/05/10 12:55:49, rohitrao (ping after 24h) wrote:
> > +sdefresne because I've never been clear on the rules for public_deps.
> 
> In src/ios, we try to limit the use of public_deps to either:
> - propagate public_configs
> - hide intermediate targets (for example //ios/web & //ios/web:web_arc).
> 
> This mean for example that if a target include a file from src/base in its
> header, we generally do not put //base in the target public_deps (even though
> base is technically part of the target public interface).
> 
> Regarding this CL, there is a need to propagate a public_configs from
> //third_party/boringssl to get the correct include path. As you can see from
the
> #include trace, the file is included by //ios/web public header, so the target
> //net should be added to //ios/web public_deps. Regarding tab.h however, I
would
> prefer if we moved the include of crw_web_delegate.h into the private API of
> tab.h, but if we don't we need to add //ios/web to //ios/chrome/browser/tabs
> public_deps.
> 
> So my recommendation are to limit the CL to the following changes:
> 1. add //net to //ios/web public_deps
> 2. add //ios/web to //ios/chrome/browser/tabs public_deps

done, with some differences:
1. The //ios/web dep actually needed to go in :web_arc due to
ios/web/public/ssl_status.h including net files
2. Left the public_deps=["//ios/chrome/browser/tabs"] in
//ios/chrome/browser/ui/tabs, because tab_view.h includes tab.h.  Or did you
want that one changed to //ios/web public_dep too?

[sdefresne, 2017-05-11 10:27:28]

lgtm

For //ios/chrome/browser/tabs, I think that Tab class should eventually be
refactored so that the ios/web/public header is not included from tab.h (but
this is a long term goal outside of the scope of this CL).

[mattm, 2017-05-11 17:07:05]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2017-05-11 17:07:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 18:34:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 18:34:50]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[mattm, 2017-05-11 18:42:23]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2017-05-11 18:43:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 19:17:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494528143131330,
"parent_rev": "8e887d183b8176e14c6800b47fc97ab67fc1957a", "commit_rev":
"2791788c6454704a4d6f8f6a917a3017b20f966a"}

[commit-bot: I haz the power, 2017-05-11 19:17:34]

Description was changed from

==========
Add public_deps for //ios/chrome/browser/tabs, //ios/chrome/browser/ui/tabs and
//ios/web


//ios/chrome/browser/tabs details:
tab.h includes files from these targets, therefore they are part of
//ios/chrome/browser/tabs public interface.

Example error:
In file included from
../../ios/chrome/browser/ui/stack_view/stack_view_egtest.mm:13:
In file included from ../../ios/chrome/browser/tabs/tab.h:17:
In file included from ../../ios/web/public/web_state/ui/crw_web_delegate.h:15:
In file included from ../../ios/web/public/ssl_status.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:71:10: fatal error:
'openssl/is_boringssl.h' file not found


//ios/chrome/browser/ui/tabs details:
tab_view.h includes headers from these targets, thus they are part of
//ios/chrome/browser/ui/tabs public interface.

Example error:
In file included from ../../ios/chrome/browser/ui/tabs/tab_strip_egtest.mm:9:
In file included from ../../ios/chrome/browser/ui/tabs/tab_view.h:11:
In file included from ../../ios/chrome/browser/tabs/tab.h:17:
In file included from ../../ios/web/public/web_state/ui/crw_web_delegate.h:15:
In file included from ../../ios/web/public/ssl_status.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:71:10: fatal error:
'openssl/is_boringssl.h' file not found


//ios/web:web_arc details:
ssl_status.h includes headers from net, thus they are part of //ios/web:web_arc
public interface.

Example error:
    In file included from
../../ios/chrome/browser/ui/payments/payment_request_manager.mm:31:
    In file included from ../../ios/web/public/ssl_status.h:12:
    In file included from ../../net/cert/x509_certificate.h:25:
    ../../third_party/boringssl/src/include/openssl/base.h:71:10: fatal error:
'openssl/is_boringssl.h' file not found


BUG=none
==========

to

==========
Add public_deps for //ios/chrome/browser/tabs, //ios/chrome/browser/ui/tabs and
//ios/web


//ios/chrome/browser/tabs details:
tab.h includes files from these targets, therefore they are part of
//ios/chrome/browser/tabs public interface.

Example error:
In file included from
../../ios/chrome/browser/ui/stack_view/stack_view_egtest.mm:13:
In file included from ../../ios/chrome/browser/tabs/tab.h:17:
In file included from ../../ios/web/public/web_state/ui/crw_web_delegate.h:15:
In file included from ../../ios/web/public/ssl_status.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:71:10: fatal error:
'openssl/is_boringssl.h' file not found


//ios/chrome/browser/ui/tabs details:
tab_view.h includes headers from these targets, thus they are part of
//ios/chrome/browser/ui/tabs public interface.

Example error:
In file included from ../../ios/chrome/browser/ui/tabs/tab_strip_egtest.mm:9:
In file included from ../../ios/chrome/browser/ui/tabs/tab_view.h:11:
In file included from ../../ios/chrome/browser/tabs/tab.h:17:
In file included from ../../ios/web/public/web_state/ui/crw_web_delegate.h:15:
In file included from ../../ios/web/public/ssl_status.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:71:10: fatal error:
'openssl/is_boringssl.h' file not found


//ios/web:web_arc details:
ssl_status.h includes headers from net, thus they are part of //ios/web:web_arc
public interface.

Example error:
    In file included from
../../ios/chrome/browser/ui/payments/payment_request_manager.mm:31:
    In file included from ../../ios/web/public/ssl_status.h:12:
    In file included from ../../net/cert/x509_certificate.h:25:
    ../../third_party/boringssl/src/include/openssl/base.h:71:10: fatal error:
'openssl/is_boringssl.h' file not found


BUG=none

Review-Url: https://codereview.chromium.org/2873203002
Cr-Commit-Position: refs/heads/master@{#471037}
Committed:
https://chromium.googlesource.com/chromium/src/+/2791788c6454704a4d6f8f6a917a...
==========

[commit-bot: I haz the power, 2017-05-11 19:17:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2791788c6454704a4d6f8f6a917a...