Chromium Code Reviews| Index: chrome/browser/ui/webui/help/help_handler.cc |
| diff --git a/chrome/browser/ui/webui/help/help_handler.cc b/chrome/browser/ui/webui/help/help_handler.cc |
| index 3cb5e474a0a3f2f5d61866c936dd4d86480d69c3..1302c1bd56b412525ef2d5b822e5a53f3a99caf1 100644 |
| --- a/chrome/browser/ui/webui/help/help_handler.cc |
| +++ b/chrome/browser/ui/webui/help/help_handler.cc |
| @@ -605,7 +605,10 @@ void HelpHandler::RequestUpdate(const base::ListValue* args) { |
| } |
| void HelpHandler::SetUpdateStatus(VersionUpdater::Status status, |
| - int progress, const base::string16& message) { |
| + int progress, |
| + const std::string& version, |
|
stevenjb
2017/05/10 23:29:05
Document that this is unused with:
const std::stri
weidongg
2017/05/11 16:34:06
Done.
|
| + const int64_t size, |
|
stevenjb
2017/05/10 23:29:05
ditto
weidongg
2017/05/11 16:34:06
Done.
|
| + const base::string16& message) { |
| // Only UPDATING state should have progress set. |
| DCHECK(status == VersionUpdater::UPDATING || progress == 0); |
| @@ -626,6 +629,9 @@ void HelpHandler::SetUpdateStatus(VersionUpdater::Status status, |
| case VersionUpdater::FAILED: |
| case VersionUpdater::FAILED_OFFLINE: |
| case VersionUpdater::FAILED_CONNECTION_TYPE_DISALLOWED: |
| + // Old help page does not support update over cellular connection. Treat this |
| + // signal as FAILED. |
| + case VersionUpdater::NEED_PERMISSION_TO_UPDATE: |
| status_str = "failed"; |
| break; |
| case VersionUpdater::DISABLED: |