Make update over cellular an option for user

chrome/browser/ui/webui/help/help_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/help/help_handler.h"
 
 #include <stddef.h>
 
 #include <string>
 
@@ skipping 587 matching lines @@
   version_updater_->CheckForUpdate(
       base::Bind(&HelpHandler::SetUpdateStatus, base::Unretained(this)),
 #if defined(OS_MACOSX)
       base::Bind(&HelpHandler::SetPromotionState, base::Unretained(this)));
 #else
       VersionUpdater::PromoteCallback());
 #endif  // OS_MACOSX
 }
 
 void HelpHandler::SetUpdateStatus(VersionUpdater::Status status,
-                                  int progress, const base::string16& message) {
+                                  int progress,
+                                  const std::string& version,

[stevenjb, 2017/05/10 23:29:05]

Document that this is unused with:
const std::string& /* version */,

[weidongg, 2017/05/11 16:34:06]

Done.

+                                  const int64_t size,

[stevenjb, 2017/05/10 23:29:05]

ditto

[weidongg, 2017/05/11 16:34:06]

Done.

+                                  const base::string16& message) {
   // Only UPDATING state should have progress set.
   DCHECK(status == VersionUpdater::UPDATING || progress == 0);
 
   std::string status_str;
   switch (status) {
   case VersionUpdater::CHECKING:
     status_str = "checking";
     break;
   case VersionUpdater::UPDATING:
     status_str = "updating";
     break;
   case VersionUpdater::NEARLY_UPDATED:
     status_str = "nearly_updated";
     break;
   case VersionUpdater::UPDATED:
     status_str = "updated";
     break;
   case VersionUpdater::FAILED:
   case VersionUpdater::FAILED_OFFLINE:
   case VersionUpdater::FAILED_CONNECTION_TYPE_DISALLOWED:
+  // Old help page does not support update over cellular connection. Treat this
+  // signal as FAILED.
+  case VersionUpdater::NEED_PERMISSION_TO_UPDATE:
     status_str = "failed";
     break;
   case VersionUpdater::DISABLED:
     status_str = "disabled";
     break;
   case VersionUpdater::DISABLED_BY_ADMIN:
     status_str = "disabled_by_admin";
     break;
   }
 
@@ skipping 113 matching lines @@
                                            base::Value("device_supported"),
                                            base::Value(""));
   } else {
     web_ui()->CallJavascriptFunctionUnsafe(
         "help.HelpPage.updateEolMessage", base::Value("device_endoflife"),
         base::Value(l10n_util::GetStringUTF16(IDS_ABOUT_PAGE_EOL_EOL)));
   }
 }
 
 #endif  // defined(OS_CHROMEOS)