Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2873173002: Fork header bar assets for new login UI (Closed)

Created:
3 years, 7 months ago by Wenzhao (Colin) Zang
Modified:
3 years, 7 months ago
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, rkc
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fork header bar assets for new login UI This CL is a follow-up to https://codereview.chromium.org/2855883005/ BUG=717779 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2873173002 Cr-Commit-Position: refs/heads/master@{#470815} Committed: https://chromium.googlesource.com/chromium/src/+/506c3df2dd4d83224aa15f8a99570d1eb4bf64df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+654 lines, -3 lines) Patch
A chrome/browser/resources/chromeos/login/md_header_bar.css View 1 chunk +169 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/md_header_bar.html View 1 chunk +64 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/md_header_bar.js View 1 chunk +418 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/md_login_shared.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/md_login_shared.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/md_screen_container.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Wenzhao (Colin) Zang
alemate@, please take a quick look. This CL only forks the additional files needed for ...
3 years, 7 months ago (2017-05-10 00:59:23 UTC) #4
jdufault
lgtm, assuming md_header_bar* and header_bar* are identical files.
3 years, 7 months ago (2017-05-10 02:33:00 UTC) #5
Alexander Alekseev
lgtm
3 years, 7 months ago (2017-05-10 22:36:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873173002/1
3 years, 7 months ago (2017-05-10 22:37:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-11 00:41:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873173002/1
3 years, 7 months ago (2017-05-11 00:43:08 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 05:08:00 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/506c3df2dd4d83224aa15f8a9957...

Powered by Google App Engine
This is Rietveld 408576698