[MD settings] adjust control spacing

[MD settings] adjust control spacing

This CL makes several small adjustments to control/item spacing as
requested by bettes@. The following items were tweaked: toggle button
width, controlled button to policy icon spacing, and ripple size on
icon buttons.

BUG=714320
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2873163002
Cr-Commit-Position: refs/heads/master@{#471908}
Committed: https://chromium.googlesource.com/chromium/src/+/9a68250c14a6e3a9053b9bd650db14943764ca95

[dschuyler, 2017-05-10 00:50:38]

Description was changed from

==========
[MD settings] adjust control spacing

This CL makes several small adjustments to control/item spacing as
requested by bettes@. The following items were tweaked: toggle button
width, controlled button to policy icon spacing, and ripple size on
icon buttons.

BUG=714320
==========

to

==========
[MD settings] adjust control spacing

This CL makes several small adjustments to control/item spacing as
requested by bettes@. The following items were tweaked: toggle button
width, controlled button to policy icon spacing, and ripple size on
icon buttons.

BUG=714320
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-05-10 00:50:41]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 00:52:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 02:55:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 02:55:20]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has
not started yet; builder either lacks capacity or does not exist (misspelled?))
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[dschuyler, 2017-05-10 19:13:22]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[dschuyler, 2017-05-10 19:14:03]

dschuyler@chromium.org changed reviewers:
+ hcarmona@chromium.org

[dschuyler, 2017-05-10 19:14:11]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-05-10 19:14:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 20:57:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 20:57:05]

Dry run: This issue passed the CQ dry run.

[hcarmona, 2017-05-15 18:24:11]

https://codereview.chromium.org/2873163002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_vars_css.html (right):

https://codereview.chromium.org/2873163002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_vars_css.html:6: <style
is="custom-style">
Is there a name conflict between this and
https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/shared_va...
where the --cr-icon-ripple-padding is defined?

[dschuyler, 2017-05-15 19:04:15]

https://codereview.chromium.org/2873163002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_vars_css.html (right):

https://codereview.chromium.org/2873163002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_vars_css.html:6: <style
is="custom-style">
On 2017/05/15 18:24:11, hcarmona wrote:
> Is there a name conflict between this and
>
https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/shared_va...
> where the --cr-icon-ripple-padding is defined?

I believe this is okay since it's saying it "is a". More info on custom-style is
at https://www.polymer-project.org/1.0/docs/devguide/styling#custom-style

[hcarmona, 2017-05-15 19:06:07]

LGTM

https://codereview.chromium.org/2873163002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_vars_css.html (right):

https://codereview.chromium.org/2873163002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_vars_css.html:6: <style
is="custom-style">
On 2017/05/15 19:04:15, dschuyler wrote:
> On 2017/05/15 18:24:11, hcarmona wrote:
> > Is there a name conflict between this and
> >
>
https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/shared_va...
> > where the --cr-icon-ripple-padding is defined?
> 
> I believe this is okay since it's saying it "is a". More info on custom-style
is
> at https://www.polymer-project.org/1.0/docs/devguide/styling#custom-style 

Acknowledged.

[dschuyler, 2017-05-15 19:09:40]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2017-05-15 19:10:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 21:34:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494875380889590,
"parent_rev": "ba864de6c45b5a5379488e3b234474d7ca574f4e", "commit_rev":
"9a68250c14a6e3a9053b9bd650db14943764ca95"}

[commit-bot: I haz the power, 2017-05-15 21:34:48]

Description was changed from

==========
[MD settings] adjust control spacing

This CL makes several small adjustments to control/item spacing as
requested by bettes@. The following items were tweaked: toggle button
width, controlled button to policy icon spacing, and ripple size on
icon buttons.

BUG=714320
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] adjust control spacing

This CL makes several small adjustments to control/item spacing as
requested by bettes@. The following items were tweaked: toggle button
width, controlled button to policy icon spacing, and ripple size on
icon buttons.

BUG=714320
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2873163002
Cr-Commit-Position: refs/heads/master@{#471908}
Committed:
https://chromium.googlesource.com/chromium/src/+/9a68250c14a6e3a9053b9bd650db...
==========

[commit-bot: I haz the power, 2017-05-15 21:34:49]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9a68250c14a6e3a9053b9bd650db...