Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js

Issue 2873153002: DevTools: Draw screenshot independently of frames bar on flamechart. (Closed)
Patch Set: addressing nits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1102 matching lines...) Expand 10 before | Expand all | Expand 10 after
1113 var parentGroupIsVisible = groupStack.peekLast().visible; 1113 var parentGroupIsVisible = groupStack.peekLast().visible;
1114 visible = thisGroupIsVisible && parentGroupIsVisible; 1114 visible = thisGroupIsVisible && parentGroupIsVisible;
1115 groupStack.push({nestingLevel: style.nestingLevel, visible: visible}); 1115 groupStack.push({nestingLevel: style.nestingLevel, visible: visible});
1116 if (parentGroupIsVisible) 1116 if (parentGroupIsVisible)
1117 currentOffset += nextLevel ? 0 : style.padding; 1117 currentOffset += nextLevel ? 0 : style.padding;
1118 this._groupOffsets[groupIndex] = currentOffset; 1118 this._groupOffsets[groupIndex] = currentOffset;
1119 if (parentGroupIsVisible && !style.shareHeaderLine) 1119 if (parentGroupIsVisible && !style.shareHeaderLine)
1120 currentOffset += style.height; 1120 currentOffset += style.height;
1121 } 1121 }
1122 var isFirstOnLevel = groupIndex >= 0 && level === groups[groupIndex].start Level; 1122 var isFirstOnLevel = groupIndex >= 0 && level === groups[groupIndex].start Level;
1123 var thisLevelIsVisible = visible || isFirstOnLevel && groups[groupIndex].s tyle.useFirstLineForOverview; 1123 var thisLevelIsVisible =
1124 parentGroupIsVisible && (visible || isFirstOnLevel && groups[groupInde x].style.useFirstLineForOverview);
1124 if (level < levelCount) { 1125 if (level < levelCount) {
1125 var height; 1126 var height;
1126 if (groupIndex >= 0) { 1127 if (groupIndex >= 0) {
1127 var group = groups[groupIndex]; 1128 var group = groups[groupIndex];
1128 var style = group.style; 1129 var style = group.style;
1129 height = isFirstOnLevel && !style.shareHeaderLine || !group.expanded ? style.height : 1130 height = isFirstOnLevel && !style.shareHeaderLine || !group.expanded ? style.height :
1130 (style.itemsHeight || this._barHeight); 1131 (style.itemsHeight || this._barHeight);
1131 } else { 1132 } else {
1132 height = this._barHeight; 1133 height = this._barHeight;
1133 } 1134 }
(...skipping 494 matching lines...) Expand 10 before | Expand all | Expand 10 after
1628 } 1629 }
1629 1630
1630 /** 1631 /**
1631 * @override 1632 * @override
1632 * @return {number} 1633 * @return {number}
1633 */ 1634 */
1634 boundarySpan() { 1635 boundarySpan() {
1635 return this._maximumBoundaries - this._minimumBoundaries; 1636 return this._maximumBoundaries - this._minimumBoundaries;
1636 } 1637 }
1637 }; 1638 };
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698