Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2873133006: Removed unecessary thread owner check. We just care about whether the lock was acquired. (Closed)

Created:
3 years, 7 months ago by nrpeter
Modified:
3 years, 7 months ago
Reviewers:
*Devlin, *dcheng
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed unecessary thread owner check. We just care about whether the lock was acquired. BUG=717596 Review-Url: https://codereview.chromium.org/2873133006 Cr-Commit-Position: refs/heads/master@{#471800} Committed: https://chromium.googlesource.com/chromium/src/+/f30da9cab0d5c860219ac2c1863bdd0202690bc4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M extensions/common/permissions/permissions_data.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
nrpeter
3 years, 7 months ago (2017-05-11 19:32:53 UTC) #4
dcheng
LGTM I agree: this change makes sense, since we're using the lock as a memory ...
3 years, 7 months ago (2017-05-12 06:39:18 UTC) #5
nrpeter
3 years, 7 months ago (2017-05-12 17:25:06 UTC) #8
Devlin
lgtm
3 years, 7 months ago (2017-05-12 21:07:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873133006/1
3 years, 7 months ago (2017-05-12 22:25:17 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/369848)
3 years, 7 months ago (2017-05-12 23:27:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873133006/1
3 years, 7 months ago (2017-05-15 15:47:47 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 16:50:15 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f30da9cab0d5c860219ac2c1863b...

Powered by Google App Engine
This is Rietveld 408576698