Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2873133004: Revert histograms for crbug.com/677365 as they're no longer needed. (Closed)

Created:
3 years, 7 months ago by pauljensen
Modified:
3 years, 7 months ago
Reviewers:
Steven Holte, tbansal1
CC:
chromium-reviews, cbentzel+watch_chromium.org, agrieve+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert histograms for crbug.com/677365 as they're no longer needed. BUG=677365 R=tbansal@chromium.org Review-Url: https://codereview.chromium.org/2873133004 Cr-Commit-Position: refs/heads/master@{#471049} Committed: https://chromium.googlesource.com/chromium/src/+/c835005daf2e585752a4ae4b26d4393216054578

Patch Set 1 #

Patch Set 2 : deprecate histograms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -25 lines) Patch
M net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java View 3 chunks +0 lines, -25 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
pauljensen
Tarun, PTAL, thank you!
3 years, 7 months ago (2017-05-11 14:32:39 UTC) #1
pauljensen
Steven, PTAL @ histograms.xml, thank you!
3 years, 7 months ago (2017-05-11 16:00:21 UTC) #3
tbansal1
lgtm
3 years, 7 months ago (2017-05-11 16:02:37 UTC) #4
tbansal1
Thanks for cleaning this up.
3 years, 7 months ago (2017-05-11 16:02:47 UTC) #5
Steven Holte
lgtm
3 years, 7 months ago (2017-05-11 17:46:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873133004/20001
3 years, 7 months ago (2017-05-11 18:33:33 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 19:49:05 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c835005daf2e585752a4ae4b26d4...

Powered by Google App Engine
This is Rietveld 408576698