Check StyleSheetIsLoading before clearing LinkStyle sheet.

Check StyleSheetIsLoading before clearing LinkStyle sheet.

StyleSheetIsLoading() returns true if the top sheet is loaded but has
loading imports. If the top level sheet is cleared before we check the
loading status, we will not appropriately call RemovedPendingSheet()
which may block rendering indefinitely.

R=meade@chromium.org,pmeenan@chromium.org
BUG=718358
Review-Url: https://codereview.chromium.org/2873133002
Cr-Commit-Position: refs/heads/master@{#470943}
Committed: https://chromium.googlesource.com/chromium/src/+/da87d9568ea3b57d705d9b8caa664f03293af321

[rune, 2017-05-10 00:25:46]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 00:27:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2017-05-10 00:29:43]

ptal

[meade_UTC10, 2017-05-10 00:34:16]

lgtm

Wow, such a small change to fix that, nice spotting!

[commit-bot: I haz the power, 2017-05-10 02:29:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 02:29:31]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has
not started yet; builder either lacks capacity or does not exist (misspelled?))
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[rune, 2017-05-10 07:44:31]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2017-05-10 07:45:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 09:52:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 09:52:18]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rune, 2017-05-10 10:10:47]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2017-05-10 10:11:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 12:25:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 12:25:48]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rune, 2017-05-10 22:41:57]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2017-05-10 22:43:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 00:51:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 00:51:20]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rune, 2017-05-11 09:56:29]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2017-05-11 09:57:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 14:06:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494496589812260, "parent_rev":
"273e9db78d78aeb54b21bc9dfcaca889d432de2c", "commit_rev":
"da87d9568ea3b57d705d9b8caa664f03293af321"}

[commit-bot: I haz the power, 2017-05-11 14:06:55]

Description was changed from

==========
Check StyleSheetIsLoading before clearing LinkStyle sheet.

StyleSheetIsLoading() returns true if the top sheet is loaded but has
loading imports. If the top level sheet is cleared before we check the
loading status, we will not appropriately call RemovedPendingSheet()
which may block rendering indefinitely.

R=meade@chromium.org,pmeenan@chromium.org
BUG=718358
==========

to

==========
Check StyleSheetIsLoading before clearing LinkStyle sheet.

StyleSheetIsLoading() returns true if the top sheet is loaded but has
loading imports. If the top level sheet is cleared before we check the
loading status, we will not appropriately call RemovedPendingSheet()
which may block rendering indefinitely.

R=meade@chromium.org,pmeenan@chromium.org
BUG=718358

Review-Url: https://codereview.chromium.org/2873133002
Cr-Commit-Position: refs/heads/master@{#470943}
Committed:
https://chromium.googlesource.com/chromium/src/+/da87d9568ea3b57d705d9b8caa66...
==========

[commit-bot: I haz the power, 2017-05-11 14:06:57]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/da87d9568ea3b57d705d9b8caa66...