Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issue 2873123005: Revert of Replace AudioFifo with a deque of AudioBus in ATR::AudioEncoder (Closed)

Created:
3 years, 7 months ago by apacible
Modified:
3 years, 7 months ago
Reviewers:
mcasas, miu, Chandan
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, emircan+watch+mediarecorder_chromium.org, mcasas+mediarecorder_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Replace AudioFifo with a deque of AudioBus in ATR::AudioEncoder (patchset #2 id:20001 of https://codereview.chromium.org/2854363002/ ) Reason for revert: Builder failing: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29 Original issue's description: > Replace AudioFifo with a deque of AudioBus in ATR::AudioEncoder > > This CL uses a std::deque<std::unique_ptr<media::AudioBus>> instead > of an AudioFifo, to avoid copying data needlessly. > > BUG=None > > Review-Url: https://codereview.chromium.org/2854363002 > Cr-Commit-Position: refs/heads/master@{#471039} > Committed: https://chromium.googlesource.com/chromium/src/+/678c74cf3e17aaef9562ee13df8c803e1d014fc6 TBR=mcasas@chromium.org,miu@chromium.org,c.padhi@samsung.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.chromium.org/2873123005 Cr-Commit-Position: refs/heads/master@{#471088} Committed: https://chromium.googlesource.com/chromium/src/+/5d0e8f61409ed3ff204140111b8cb70be3a3d473

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -25 lines) Patch
M content/renderer/media_recorder/audio_track_recorder.cc View 8 chunks +13 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
apacible
Created Revert of Replace AudioFifo with a deque of AudioBus in ATR::AudioEncoder
3 years, 7 months ago (2017-05-11 22:23:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873123005/1
3 years, 7 months ago (2017-05-11 22:24:36 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 22:25:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5d0e8f61409ed3ff204140111b8c...

Powered by Google App Engine
This is Rietveld 408576698