Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Issue 2873123003: Make IDS_PRIVATE_USER_DATA_INPUT_DESCRIPTION platform independent (Closed)

Created:
3 years, 7 months ago by elawrence
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make IDS_PRIVATE_USER_DATA_INPUT_DESCRIPTION platform independent IDS_PRIVATE_USER_DATA_INPUT_DESCRIPTION should live in the platform independent security_state_strings.grdp file, because its content is the same across Chrome/Chromium. BUG=720050 Review-Url: https://codereview.chromium.org/2873123003 Cr-Commit-Position: refs/heads/master@{#470956} Committed: https://chromium.googlesource.com/chromium/src/+/30af3e848371859a5cea265fac96e909f8cb6b5f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M components/components_chromium_strings.grd View 1 chunk +0 lines, -5 lines 0 comments Download
M components/components_google_chrome_strings.grd View 1 chunk +0 lines, -5 lines 0 comments Download
M components/security_state_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
elawrence
PTAL at this trivial string move?
3 years, 7 months ago (2017-05-10 18:04:59 UTC) #2
estark
lgtm
3 years, 7 months ago (2017-05-11 01:08:16 UTC) #4
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-11 07:55:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873123003/1
3 years, 7 months ago (2017-05-11 12:25:57 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 14:59:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/30af3e848371859a5cea265fac96...

Powered by Google App Engine
This is Rietveld 408576698