Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2873113002: auth: Remove "shared" aka "global" secrets. (Closed)

Created:
3 years, 7 months ago by Vadim Sh.
Modified:
3 years, 7 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -261 lines) Patch
M appengine/gaeauth/server/db.go View 2 chunks +0 lines, -5 lines 0 comments Download
M server/auth/auth_test.go View 2 chunks +0 lines, -5 lines 0 comments Download
M server/auth/authdb/db.go View 2 chunks +0 lines, -7 lines 0 comments Download
M server/auth/authdb/erroring.go View 2 chunks +0 lines, -10 lines 0 comments Download
M server/auth/authdb/snapshot.go View 4 chunks +0 lines, -29 lines 0 comments Download
M server/auth/authdb/snapshot_test.go View 2 chunks +0 lines, -42 lines 0 comments Download
M server/auth/authtest/db.go View 2 chunks +0 lines, -7 lines 0 comments Download
M server/auth/service/protocol/replication.proto View 4 chunks +3 lines, -18 lines 0 comments Download
M server/auth/service/protocol/replication.pb.go View 16 chunks +76 lines, -138 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Vadim Sh.
Code removal, yay!
3 years, 7 months ago (2017-05-10 00:11:36 UTC) #1
iannucci
\o/ lgtm
3 years, 7 months ago (2017-05-10 05:10:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873113002/1
3 years, 7 months ago (2017-05-10 17:05:11 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 17:16:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/172994b061ceb23138f51c0a4f937e979b51a895

Powered by Google App Engine
This is Rietveld 408576698