Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2873083002: Propagate viewport intersection across OOPIFs at the correct time (Closed)

Created:
3 years, 7 months ago by Charlie Reis
Modified:
3 years, 7 months ago
Reviewers:
kenrb, dcheng
CC:
chromium-reviews, szager1
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Propagate viewport intersection across OOPIFs at the correct time This corrects a couple of issues with how viewport intersection rects were being sent to OOPIF processes from their parents, which was causing frame throttling bugs: 1. The update is now triggered from the parent FrameView's UpdateViewportIntersectionsForSubtree, rather than the RemoteFrameView's frameRectsChanged. Formerly, this would cause intersection calculations in a dirty layout tree, and also fail to propagate intersection rect changes in the case of nested OOPIFs. 2. Viewport intersections are now updated properly when the iframe is scrolled off of screen. Previously it would return early when an OOPIF had no viewport intersection, which was wrong. BUG=682307, 712320 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2860903003 Cr-Commit-Position: refs/heads/master@{#469977} (cherry picked from commit 321a171abcca381e3ef72d01996e4ae4dd860212) Review-Url: https://codereview.chromium.org/2873083002 . Cr-Commit-Position: refs/branch-heads/3071@{#489} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/c4999457b7f0e7121f4067d9bdf86a93299a8c94

Patch Set 1 #

Messages

Total messages: 4 (2 generated)
Charlie Reis
FYI: Merging to M59.
3 years, 7 months ago (2017-05-09 23:05:16 UTC) #2
Charlie Reis
3 years, 7 months ago (2017-05-09 23:05:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c4999457b7f0e7121f4067d9bdf86a93299a8c94.

Powered by Google App Engine
This is Rietveld 408576698