fix #29585, implement equality for tearoffs

fix #29585, implement equality for tearoffs

R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/4c377076bfb340612b72e13daab396ac35398aef

[Jennifer Messerly, 2017-05-09 22:44:03]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2017-05-09 22:44:04]

note, I moved this into "operations.dart" which is where stuff that is called
from expressions like `dsend` lives. "classes.dart" is stuff that supports class
declarations themselves. mostly load time code.

[vsm, 2017-05-09 22:50:16]

lgtm

https://codereview.chromium.org/2873073002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart
(right):

https://codereview.chromium.org/2873073002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart:56: return
other[#] === this[#] && other[#] === this[#];
check other is non-null too?

[Jennifer Messerly, 2017-05-09 23:10:34]

https://codereview.chromium.org/2873073002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart
(right):

https://codereview.chromium.org/2873073002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart:56: return
other[#] === this[#] && other[#] === this[#];
On 2017/05/09 22:50:15, vsm wrote:
> check other is non-null too?

equality operator is spec'd to check for this:

Evaluation of an equality expression ee of the form e1 == e2 proceeds as
follows:
• The expression e1 is evaluated to an object o1.
• The expression e2 is evaluated to an object o2.
• If either o1 or o2 is null, then ee evaluates to true if both o1 and o2 are
null and to false otherwise. Otherwise,
• ee is equivalent to the method invocation o1.==(o2).

[Jennifer Messerly, 2017-05-09 23:11:17]

https://codereview.chromium.org/2873073002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart
(right):

https://codereview.chromium.org/2873073002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart:56: return
other[#] === this[#] && other[#] === this[#];
On 2017/05/09 23:10:33, Jennifer Messerly wrote:
> On 2017/05/09 22:50:15, vsm wrote:
> > check other is non-null too?
> 
> equality operator is spec'd to check for this:
> 
> Evaluation of an equality expression ee of the form e1 == e2 proceeds as
> follows:
> • The expression e1 is evaluated to an object o1.
> • The expression e2 is evaluated to an object o2.
> • If either o1 or o2 is null, then ee evaluates to true if both o1 and o2 are
> null and to false otherwise. Otherwise,
> • ee is equivalent to the method invocation o1.==(o2).

(in other words, it checks before the operator method is called ... see
dart.equals)

[Jennifer Messerly, 2017-05-09 23:22:00]

Description was changed from

==========
fix #29585, implement equality for tearoffs
==========

to

==========
fix #29585, implement equality for tearoffs

R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4c377076bfb340612b72e13daab396ac35398aef
==========

[Jennifer Messerly, 2017-05-09 23:22:01]

Committed patchset #2 (id:10001) manually as
4c377076bfb340612b72e13daab396ac35398aef (presubmit successful).