fix #29585, implement equality for tearoffs

pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// This library defines runtime operations on objects used by the code
 /// generator.
 part of dart._runtime;
 
 class InvocationImpl extends Invocation {
   final Symbol memberName;
@@ skipping 11 matching lines @@
       : memberName = _dartSymbol(memberName),
         namedArguments = _namedArgsToSymbols(namedArguments);
 
   static Map<Symbol, dynamic> _namedArgsToSymbols(namedArgs) {
     if (namedArgs == null) return {};
     return new Map.fromIterable(getOwnPropertyNames(namedArgs),
         key: _dartSymbol, value: (k) => JS('', '#[#]', namedArgs, k));
   }
 }
 
+/// Given an object and a method name, tear off the method.
+/// Sets the runtime type of the torn off method appropriately,
+/// and also binds the object.
+///
+/// If the optional `f` argument is passed in, it will be used as the method.
+/// This supports cases like `super.foo` where we need to tear off the method
+/// from the superclass, not from the `obj` directly.
+/// TODO(leafp): Consider caching the tearoff on the object?
+bind(obj, name, f) {
+  if (f == null) f = JS('', '#[#]', obj, name);
+
+  // TODO(jmesserly): it would be nice to do this lazily, but JS interop seems
+  // to require us to be eager (the test below).
+  var sig = getMethodType(getType(obj), name);
+
+  // JS interop case: do not bind this for compatibility with the dart2js
+  // implementation where we cannot bind this reliably here until we trust
+  // types more.
+  if (sig == null) return f;
+
+  f = JS('', '#.bind(#)', f, obj);
+  JS(
+      '',
+      r'''#[dartx["=="]] = function boundMethodEquals(other) {
+    return other[#] === this[#] && other[#] === this[#];

[vsm, 2017/05/09 22:50:15]

check other is non-null too?

[Jennifer Messerly, 2017/05/09 23:10:33]

equality operator is spec'd to check for this:

Evaluation of an equality expression ee of the form e1 == e2 proceeds as
follows:
• The expression e1 is evaluated to an object o1.
• The expression e2 is evaluated to an object o2.
• If either o1 or o2 is null, then ee evaluates to true if both o1 and o2 are
null and to false otherwise. Otherwise,
• ee is equivalent to the method invocation o1.==(o2).

[Jennifer Messerly, 2017/05/09 23:11:17]

(in other words, it checks before the operator method is called ... see
dart.equals)

+  }''',
+      f,
+      _boundMethodTarget,
+      _boundMethodTarget,
+      _boundMethodName,
+      _boundMethodName);
+  JS('', '#[#] = #', f, _boundMethodTarget, obj);
+  JS('', '#[#] = #', f, _boundMethodName, name);
+  tag(f, sig);
+  return f;
+}
+
+final _boundMethodTarget = JS('', 'Symbol("_boundMethodTarget")');
+final _boundMethodName = JS('', 'Symbol("_boundMethodName")');
+
+/// Instantiate a generic method.
+///
+/// We need to apply the type arguments both to the function, as well as its
+/// associated function type.
+gbind(f, @rest typeArgs) {
+  var result = JS('', '#.apply(null, #)', f, typeArgs);
+  var sig = JS('', '#.instantiate(#)', _getRuntimeType(f), typeArgs);
+  tag(result, sig);
+  return result;
+}
+
 // Warning: dload, dput, and dsend assume they are never called on methods
 // implemented by the Object base class as those methods can always be
 // statically resolved.
 dload(obj, field) {
   var f = _canonicalMember(obj, field);
 
   _trackCall(obj);
   if (f != null) {
     var type = getType(obj);
 
@@ skipping 866 matching lines @@
     name = '+' + name;
   }
   return name;
 }
 
 /// Emulates the implicit "loadLibrary" function provided by a deferred library.
 ///
 /// Libraries are not actually deferred in DDC, so this just returns a future
 /// that completes immediately.
 Future loadLibrary() => new Future.value();