Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: runtime/observatory/lib/src/elements/code_view.dart

Issue 2873013004: Omnibus Observatory UI fixes: (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/code_view.dart
diff --git a/runtime/observatory/lib/src/elements/code_view.dart b/runtime/observatory/lib/src/elements/code_view.dart
index bbbde907042170029fa46dd21695f2311e4aeb2f..c33933627c66731119e56ce642782ad6962eb2b6 100644
--- a/runtime/observatory/lib/src/elements/code_view.dart
+++ b/runtime/observatory/lib/src/elements/code_view.dart
@@ -64,7 +64,7 @@ class CodeViewElement extends HtmlElement implements Renderable {
M.ReachableSizeRepository _reachableSizes;
M.InboundReferencesRepository _references;
M.RetainingPathRepository _retainingPaths;
- M.InstanceRepository _instances;
+ M.ObjectRepository _objects;
DisassemblyTable disassemblyTable;
InlineTable inlineTable;
@@ -85,14 +85,14 @@ class CodeViewElement extends HtmlElement implements Renderable {
M.ReachableSizeRepository reachableSizes,
M.InboundReferencesRepository references,
M.RetainingPathRepository retainingPaths,
- M.InstanceRepository instances,
+ M.ObjectRepository objects,
{RenderingQueue queue}) {
assert(vm != null);
assert(isolate != null);
assert(events != null);
assert(notifications != null);
assert(code != null);
- assert(instances != null);
+ assert(objects != null);
assert(retainedSizes != null);
assert(reachableSizes != null);
assert(references != null);
@@ -104,7 +104,7 @@ class CodeViewElement extends HtmlElement implements Renderable {
e._events = events;
e._notifications = notifications;
e._code = code;
- e._instances = instances;
+ e._objects = objects;
e._retainedSizes = retainedSizes;
e._reachableSizes = reachableSizes;
e._references = references;
@@ -225,7 +225,7 @@ class CodeViewElement extends HtmlElement implements Renderable {
: 'Code for ${_code.name}',
new HRElement(),
new ObjectCommonElement(_isolate, _code, _retainedSizes,
- _reachableSizes, _references, _retainingPaths, _instances,
+ _reachableSizes, _references, _retainingPaths, _objects,
queue: _r.queue),
new BRElement(),
new DivElement()
@@ -476,9 +476,7 @@ class CodeViewElement extends HtmlElement implements Renderable {
final cell = tr.children[i];
final content = row.values[i];
if (content is S.HeapObject) {
- cell.children = [
- anyRef(_isolate, content, _instances, queue: _r.queue)
- ];
+ cell.children = [anyRef(_isolate, content, _objects, queue: _r.queue)];
} else if (content != null) {
String text = '$content';
if (i == kDisassemblyColumnIndex) {
« no previous file with comments | « runtime/observatory/lib/src/elements/class_view.dart ('k') | runtime/observatory/lib/src/elements/context_ref.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698