Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2872983002:
Reuse AXPlatformNodeBase::Init to set owner. (Closed)
|
Created:
3 years, 7 months ago by dougt Modified:
3 years, 4 months ago Reviewers:
dmazzoni CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionReuse AXPlatformNodeBase::Init to set owner.
BUG=703369
Review-Url: https://codereview.chromium.org/2872983002
Cr-Commit-Position: refs/heads/master@{#471080}
Committed: https://chromium.googlesource.com/chromium/src/+/8f57fb3c6faf2347318e9a5fc2fb7796ea508903
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #
Messages
Total messages: 29 (14 generated)
dougt@chromium.org changed reviewers: + dmazzoni@chromium.org
ptal I am not really happy with this approach due to the static_cast. However, reusing the Init() does make things cleaner than having two initialization methods for this class. WDYT?
lgtm I'm okay with this - it reinforces the idea that eventually we should only access GetDelegate() and not GetOwner().
The CQ bit was checked by dougt@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dmazzoni@chromium.org Link to the patchset: https://codereview.chromium.org/2872983002/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by dougt@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dmazzoni@chromium.org Link to the patchset: https://codereview.chromium.org/2872983002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
try to find reaserches about this bug on https://yourwriters.net/, they have lots of samples
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by dougt@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by dougt@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by dougt@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494532961717740,
"parent_rev": "51d2ef457b0e77fa0f170f1a5ca89d039cf69b04", "commit_rev":
"8f57fb3c6faf2347318e9a5fc2fb7796ea508903"}
Message was sent while issue was closed.
Description was changed from ========== Reuse AXPlatformNodeBase::Init to set owner. BUG=703369 ========== to ========== Reuse AXPlatformNodeBase::Init to set owner. BUG=703369 Review-Url: https://codereview.chromium.org/2872983002 Cr-Commit-Position: refs/heads/master@{#471080} Committed: https://chromium.googlesource.com/chromium/src/+/8f57fb3c6faf2347318e9a5fc2fb... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/8f57fb3c6faf2347318e9a5fc2fb...
Message was sent while issue was closed.
On 2017/05/11 09:05:10, tiffany.mays80s wrote: > try to find reaserches about this bug on https://yourwriters.net/, they have > lots of samples Can you please also check https://sigmaessays.com/ for the same issues? Thx
Message was sent while issue was closed.
Sorry, I don't understand the last comment. Is this spam? |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
