Use URLRequestContextStorage for the SystemURLRequestContext.

Use URLRequestContextStorage for the SystemURLRequestContext.

Not all members are currently stored in it, but I plan to switch them
over in a followup CL.

This is one of the steps in switching the system URLRequestContext over
to using a URLRequestContextBuilder.  The other steps are getting rid of
the ProxyURLRequestContext, and making the builder able to create a
ProxyService that uses V8 (Both with and without mojo).

BUG=715695
Review-Url: https://codereview.chromium.org/2872903006
Cr-Commit-Position: refs/heads/master@{#471844}
Committed: https://chromium.googlesource.com/chromium/src/+/f2e53b2bec633349e045fd4566d841289a295247

[mmenke, 2017-05-09 19:52:06]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 19:52:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 20:26:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 20:26:28]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[mmenke, 2017-05-10 16:06:07]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 16:07:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-05-10 18:07:53]

mmenke@chromium.org changed reviewers:
+ rdsmith@chromium.org

[mmenke, 2017-05-10 18:07:54]

Randy:  Going to try and move creation of everything inline, get rid of the
ProxyScriptFetchingURLRequestContext, and then switch to using a
URLRequestContextBuilder (And then, for everything that the builder already
supports, just remove the corresponding creation lines from IOThread).

I'm hoping to keep the CLs relatively small-ish, so they're easier to review. 
Note that this CL is on top of another CL that I've sent to eroman for review,
which makes it so the SystemURLRequestContext is created in IOThread::Init.

https://codereview.chromium.org/2872903006/diff/20001/chrome/browser/io_threa...
File chrome/browser/io_thread.cc (right):

https://codereview.chromium.org/2872903006/diff/20001/chrome/browser/io_threa...
chrome/browser/io_thread.cc:905: WpadQuickCheckEnabled(),
PacHttpsUrlStrippingEnabled()));
Had to move proxy creation to just before it's used in the
SetHttpNetworkSessionComponents below, since it now relies on some parts of the
system URLRequestContext.  I'll switch this over to using the system request
context at some point.

[commit-bot: I haz the power, 2017-05-10 18:35:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 18:35:43]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Randy Smith (Not in Mondays), 2017-05-10 21:54:48]

lgtm

https://codereview.chromium.org/2872903006/diff/20001/chrome/browser/io_threa...
File chrome/browser/io_thread.cc (right):

https://codereview.chromium.org/2872903006/diff/20001/chrome/browser/io_threa...
chrome/browser/io_thread.cc:905: WpadQuickCheckEnabled(),
PacHttpsUrlStrippingEnabled()));
On 2017/05/10 18:07:54, mmenke wrote:
> Had to move proxy creation to just before it's used in the
> SetHttpNetworkSessionComponents below, since it now relies on some parts of
the
> system URLRequestContext.  I'll switch this over to using the system request
> context at some point.

I'm missing the dependencies; can you spell them out?

(Not gonna block the CL on this because this a perfectly fine place for the
creation to happen--I just want to understand for future CLs.)

[mmenke, 2017-05-10 22:28:14]

On 2017/05/10 21:54:48, Randy Smith (Not in Mondays) wrote:
> lgtm
> 
>
https://codereview.chromium.org/2872903006/diff/20001/chrome/browser/io_threa...
> File chrome/browser/io_thread.cc (right):
> 
>
https://codereview.chromium.org/2872903006/diff/20001/chrome/browser/io_threa...
> chrome/browser/io_thread.cc:905: WpadQuickCheckEnabled(),
> PacHttpsUrlStrippingEnabled()));
> On 2017/05/10 18:07:54, mmenke wrote:
> > Had to move proxy creation to just before it's used in the
> > SetHttpNetworkSessionComponents below, since it now relies on some parts of
> the
> > system URLRequestContext.  I'll switch this over to using the system request
> > context at some point.
> 
> I'm missing the dependencies; can you spell them out?
> 
> (Not gonna block the CL on this because this a perfectly fine place for the
> creation to happen--I just want to understand for future CLs.)

See the lines I modified in the ProxyScriptFetcherURLRequestContext
configuration section (Line 1049) - it grabs the cookie store and channel ID
store from the system request context.  It used to grab them from globals, but I
removed them from globals, and moved initialization down to when the system
request context is created.  And since we need the ProxyService before we can
finish creating the system request context, have to mix the creation order, due
to the circular dependency (Which is a bit ugly, admittedly).

[mmenke, 2017-05-15 16:39:31]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-05-15 16:40:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 18:40:24]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494866371597240,
"parent_rev": "611466a4430557a67478d236ac57dc649b6eee99", "commit_rev":
"f2e53b2bec633349e045fd4566d841289a295247"}

[commit-bot: I haz the power, 2017-05-15 18:40:33]

Description was changed from

==========
Use URLRequestContextStorage for the SystemURLRequestContext.

Not all members are currently stored in it, but I plan to switch them
over in a followup CL.

This is one of the steps in switching the system URLRequestContext over
to using a URLRequestContextBuilder.  The other steps are getting rid of
the ProxyURLRequestContext, and making the builder able to create a
ProxyService that uses V8 (Both with and without mojo).

BUG=715695
==========

to

==========
Use URLRequestContextStorage for the SystemURLRequestContext.

Not all members are currently stored in it, but I plan to switch them
over in a followup CL.

This is one of the steps in switching the system URLRequestContext over
to using a URLRequestContextBuilder.  The other steps are getting rid of
the ProxyURLRequestContext, and making the builder able to create a
ProxyService that uses V8 (Both with and without mojo).

BUG=715695

Review-Url: https://codereview.chromium.org/2872903006
Cr-Commit-Position: refs/heads/master@{#471844}
Committed:
https://chromium.googlesource.com/chromium/src/+/f2e53b2bec633349e045fd4566d8...
==========

[commit-bot: I haz the power, 2017-05-15 18:40:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f2e53b2bec633349e045fd4566d8...