[Mac] Nil out content shell window delegate on close

[Mac] Nil out content shell window delegate on close

On TouchBar Macs, the touch bar provider system overretains
windows that are closed while the application is backgrounded.
See crbug.com/667274 for details.

In content shell, this leaves the window with a dangling delegate
pointer and can cause crashes in layout tests.

BUG=719830
Review-Url: https://codereview.chromium.org/2872903004
Cr-Commit-Position: refs/heads/master@{#470565}
Committed: https://chromium.googlesource.com/chromium/src/+/8fdcb922fcb704745bcd2b4376605582bea0f54d

[lgrey, 2017-05-09 18:21:34]

lgrey@chromium.org changed reviewers:
+ pdr@google.com

[lgrey, 2017-05-09 18:21:34]

PTAL

[pdr., 2017-05-09 20:02:15]

On 2017/05/09 at 18:21:34, lgrey wrote:
> PTAL

I confirmed this fixes the issue, thanks! I really don't know this actual code
enough to give you an LGTM to land though.

[lgrey, 2017-05-09 20:07:36]

lgrey@chromium.org changed reviewers:
+ avi@chromium.org

[lgrey, 2017-05-09 20:07:36]

Avi, do you have some context on this? (Also, I need you for content OWNERS :))

[Avi (use Gerrit), 2017-05-09 22:22:24]

This is definitely worthy of a comment in the code as to why we're doing this.
LGTM with one.

[lgrey, 2017-05-09 23:18:04]

On 2017/05/09 22:22:24, Avi (ping after 24h) wrote:
> This is definitely worthy of a comment in the code as to why we're doing this.
> LGTM with one.

Thanks! Done

[lgrey, 2017-05-09 23:18:07]

The CQ bit was checked by lgrey@chromium.org

[lgrey, 2017-05-09 23:18:07]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2872903004/#ps20001
(title: "Comment")

[commit-bot: I haz the power, 2017-05-09 23:19:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 01:21:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 01:21:54]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has
not started yet; builder either lacks capacity or does not exist (misspelled?))
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[lgrey, 2017-05-10 14:29:27]

The CQ bit was checked by lgrey@chromium.org

[commit-bot: I haz the power, 2017-05-10 14:29:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 14:36:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494426567199060,
"parent_rev": "0cdd7d5c0f0c9e6410fc0d036382857535026701", "commit_rev":
"8fdcb922fcb704745bcd2b4376605582bea0f54d"}

[commit-bot: I haz the power, 2017-05-10 14:36:36]

Description was changed from

==========
[Mac] Nil out content shell window delegate on close

On TouchBar Macs, the touch bar provider system overretains
windows that are closed while the application is backgrounded.
See crbug.com/667274 for details.

In content shell, this leaves the window with a dangling delegate
pointer and can cause crashes in layout tests.

BUG=719830
==========

to

==========
[Mac] Nil out content shell window delegate on close

On TouchBar Macs, the touch bar provider system overretains
windows that are closed while the application is backgrounded.
See crbug.com/667274 for details.

In content shell, this leaves the window with a dangling delegate
pointer and can cause crashes in layout tests.

BUG=719830

Review-Url: https://codereview.chromium.org/2872903004
Cr-Commit-Position: refs/heads/master@{#470565}
Committed:
https://chromium.googlesource.com/chromium/src/+/8fdcb922fcb704745bcd2b437660...
==========

[commit-bot: I haz the power, 2017-05-10 14:36:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8fdcb922fcb704745bcd2b437660...