Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2872903002: Reland: Statically link own version of FreeType on Linux (Closed)

Created:
3 years, 7 months ago by drott
Modified:
3 years, 7 months ago
CC:
chromium-reviews, grt+watch_chromium.org, Michael Moss, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Statically link own version of FreeType on Linux For color font support, CFF and CFF2 rasterization, and OpenType font variations, latest security fixes, Chrome needs an up-to-date version of FreeType (more details on the bug). Since distributions are too far behind in the shipped system FreeType versions, we need to start linking in our own copy. For distributions that build their own Chromium this CL introduces a switch use_system_freetype which can be used to keep the old linking configuration at the expense of risking introduction of text rendering and security regressions if the system FreeType is too old. Reland with fixed installer dependency expectations, after revert in https://codereview.chromium.org/2868793004/ TBR, because previously reviewed in https://codereview.chromium.org/2863063003 BUG=274030 TBR=thomasanderson, dpranke Review-Url: https://codereview.chromium.org/2872903002 Cr-Commit-Position: refs/heads/master@{#470273} Committed: https://chromium.googlesource.com/chromium/src/+/5cfc439201cc3a8700c9b202d6a53c78b362baf0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -13 lines) Patch
M build/config/freetype/BUILD.gn View 1 chunk +12 lines, -1 line 0 comments Download
M build/config/linux/pangocairo/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
M build/linux/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/linux/debian/expected_deps_ia32_jessie View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/linux/debian/expected_deps_x64_jessie View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/linux/rpm/expected_deps_i386 View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/linux/rpm/expected_deps_x86_64 View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/freetype/README.chromium View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
drott
3 years, 7 months ago (2017-05-09 07:06:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872903002/1
3 years, 7 months ago (2017-05-09 07:06:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5cfc439201cc3a8700c9b202d6a53c78b362baf0
3 years, 7 months ago (2017-05-09 10:10:10 UTC) #8
eae
LGTM
3 years, 7 months ago (2017-05-09 15:15:45 UTC) #9
Dirk Pranke
3 years, 7 months ago (2017-05-09 20:11:56 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698