Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2872873002:
Work around for crbug.com/719609 (Closed)
|
Created:
3 years, 7 months ago by jungshik at Google Modified:
3 years, 7 months ago CC:
v8-reviews_googlegroups.com Target Ref:
refs/heads/master Project:
v8 Visibility:
Public. |
DescriptionWork around for crbug.com/719609
Temporarily disable check for Etc/GMT and take it as well as
Etc/UTC until the root cause of crbug.com/719609 is found.
BUG=chromium:719609, v8:6252
TBR=adamk@chromium.org
Review-Url: https://codereview.chromium.org/2872873002
Cr-Commit-Position: refs/heads/master@{#45186}
Committed: https://chromium.googlesource.com/v8/v8/+/f64f98460301bc349511b32637ada8bd2d7e0567
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
The CQ bit was checked by jshin@chromium.org to run a CQ dry run
The CQ bit was unchecked by jshin@chromium.org
The CQ bit was checked by jshin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
jshin@chromium.org changed reviewers: + littledan@chromium.org
Asking Dan because he's in a better timezone :-)
Description was changed from ========== Work around for crbug.com/719609 Temporarily disable check for Etc/GMT and take it as well as Etc/UTC until the root cause of crbug.com/719609 is found. BUG=chromium:719609 TBR=adamk@chromium.org ========== to ========== Work around for crbug.com/719609 Temporarily disable check for Etc/GMT and take it as well as Etc/UTC until the root cause of crbug.com/719609 is found. BUG=chromium:719609,v8:6252 TBR=adamk@chromium.org ==========
machenbach@chromium.org changed reviewers: + machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
machenbach@, can you approve? Because I'm not in v8-commiter list, TBR does not work for me. Thanks !
On 2017/05/09 08:47:01, jungshik at Google wrote: > machenbach@, can you approve? > > Because I'm not in v8-commiter list, TBR does not work for me. > > Thanks ! Oh, you beat me to that. Thanks !
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494319572964210, "parent_rev":
"d412cade2a889f6b208c7c7c078209ea81538013", "commit_rev":
"f64f98460301bc349511b32637ada8bd2d7e0567"}
Message was sent while issue was closed.
Description was changed from ========== Work around for crbug.com/719609 Temporarily disable check for Etc/GMT and take it as well as Etc/UTC until the root cause of crbug.com/719609 is found. BUG=chromium:719609,v8:6252 TBR=adamk@chromium.org ========== to ========== Work around for crbug.com/719609 Temporarily disable check for Etc/GMT and take it as well as Etc/UTC until the root cause of crbug.com/719609 is found. BUG=chromium:719609,v8:6252 TBR=adamk@chromium.org Review-Url: https://codereview.chromium.org/2872873002 Cr-Commit-Position: refs/heads/master@{#45186} Committed: https://chromium.googlesource.com/v8/v8/+/f64f98460301bc349511b32637ada8bd2d7... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/f64f98460301bc349511b32637ada8bd2d7... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
