Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2872863003:
Use base::FileDescriptorWatcher instead of MessageLoopForIO::WatchFileDescriptor in proxy_config_se… (Closed)
DescriptionUse base::FileDescriptorWatcher instead of MessageLoopForIO::WatchFileDescriptor in proxy_config_service_linux.cc
base::FileDescriptorWatcher is the equivalent MessageLoop independent API
(the only difference is an extra PostTask hop on notification which is irrelevant
for low volume handles)
This MessageLoopForIO::WatchFileDescriptor is causing problems @ https://bugs.chromium.org/p/chromium/issues/detail?id=653916#c47
per the FILE thread's MessageLoop going away.
BUG=645114, 653916
Review-Url: https://codereview.chromium.org/2872863003
Cr-Commit-Position: refs/heads/master@{#470702}
Committed: https://chromium.googlesource.com/chromium/src/+/f4f904edc4cbbb9ffd269cd6fd5d26d9925aee8c
Patch Set 1 #Patch Set 2 : fix compile #Messages
Total messages: 26 (20 generated)
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Use base::FileDescriptorWatcher instead of MessageLoopForIO::WatchFileDescriptor in proxy_config_service_linux.cc base::FileDescriptorWatcher is the equivalent MessageLoop independent API (the only difference is an extra PostTask hop on notification which is irrelevant for low volume handles) BUG=645114, 653916 ========== to ========== Use base::FileDescriptorWatcher instead of MessageLoopForIO::WatchFileDescriptor in proxy_config_service_linux.cc base::FileDescriptorWatcher is the equivalent MessageLoop independent API (the only difference is an extra PostTask hop on notification which is irrelevant for low volume handles) Causes problems @ https://bugs.chromium.org/p/chromium/issues/detail?id=653916#c47 per the FILE thread's MessageLoop going away. BUG=645114, 653916 ==========
gab@chromium.org changed reviewers: + mattm@chromium.org
Matt PTaL and CQ if LGTY, thanks!
Description was changed from ========== Use base::FileDescriptorWatcher instead of MessageLoopForIO::WatchFileDescriptor in proxy_config_service_linux.cc base::FileDescriptorWatcher is the equivalent MessageLoop independent API (the only difference is an extra PostTask hop on notification which is irrelevant for low volume handles) Causes problems @ https://bugs.chromium.org/p/chromium/issues/detail?id=653916#c47 per the FILE thread's MessageLoop going away. BUG=645114, 653916 ========== to ========== Use base::FileDescriptorWatcher instead of MessageLoopForIO::WatchFileDescriptor in proxy_config_service_linux.cc base::FileDescriptorWatcher is the equivalent MessageLoop independent API (the only difference is an extra PostTask hop on notification which is irrelevant for low volume handles) This MessageLoopForIO::WatchFileDescriptor is causing problems @ https://bugs.chromium.org/p/chromium/issues/detail?id=653916#c47 per the FILE thread's MessageLoop going away. BUG=645114, 653916 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
raphael.kubo.da.costa@intel.com changed reviewers: + raphael.kubo.da.costa@intel.com
non-owner l-g-t-m: I can confirm this fixes the crashes on startup I'm having.
fdoray@chromium.org changed reviewers: + fdoray@chromium.org
lgtm
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mattm@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494449117252490,
"parent_rev": "6f3a10ddea2ee602ff61267ce3ed6a60c8e6ff71", "commit_rev":
"f4f904edc4cbbb9ffd269cd6fd5d26d9925aee8c"}
Message was sent while issue was closed.
Description was changed from ========== Use base::FileDescriptorWatcher instead of MessageLoopForIO::WatchFileDescriptor in proxy_config_service_linux.cc base::FileDescriptorWatcher is the equivalent MessageLoop independent API (the only difference is an extra PostTask hop on notification which is irrelevant for low volume handles) This MessageLoopForIO::WatchFileDescriptor is causing problems @ https://bugs.chromium.org/p/chromium/issues/detail?id=653916#c47 per the FILE thread's MessageLoop going away. BUG=645114, 653916 ========== to ========== Use base::FileDescriptorWatcher instead of MessageLoopForIO::WatchFileDescriptor in proxy_config_service_linux.cc base::FileDescriptorWatcher is the equivalent MessageLoop independent API (the only difference is an extra PostTask hop on notification which is irrelevant for low volume handles) This MessageLoopForIO::WatchFileDescriptor is causing problems @ https://bugs.chromium.org/p/chromium/issues/detail?id=653916#c47 per the FILE thread's MessageLoop going away. BUG=645114, 653916 Review-Url: https://codereview.chromium.org/2872863003 Cr-Commit-Position: refs/heads/master@{#470702} Committed: https://chromium.googlesource.com/chromium/src/+/f4f904edc4cbbb9ffd269cd6fd5d... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f4f904edc4cbbb9ffd269cd6fd5d... |
