Revert a change of disabling translation from context menu temporarily

Revert a change of disabling translation from context menu temporarily

The translation should be disabled if the feature is disabled by
PolicyList, but the submitted change disables the translation even when
a user disables it from the setting.

Manually triggering a translation from the context menu is one important
use case for users who do not want Chrome to suggest translation, but
need manual translation.

I quickly revert the last change, and will revisit later to remove the
menu only when the feature is disabled by PolicyList.

BUG=711217
Review-Url: https://codereview.chromium.org/2872813004
Cr-Commit-Position: refs/heads/master@{#470479}
Committed: https://chromium.googlesource.com/chromium/src/+/a942138fe716b963ce8247cdcbd3082e841fd19c

[Takashi Toyoshima, 2017-05-09 11:30:53]

Description was changed from

==========
Revert a change of disabling translation from context menu temporarily

The translation should be disabled if the feature is disabled by
PolicyList, but the submitted change disables the translation even when
a user disables it from the setting.

Manually triggering a translation from the context menu is one important
use case for users who do not want Chrome to suggest translation, but
need manual translation.

I quickly revert the last change, and will revisit later to remove the
menu only when the feature is disabled by PolicyList.

BUG=711217
==========

to

==========
Revert a change of disabling translation from context menu temporarily

The translation should be disabled if the feature is disabled by
PolicyList, but the submitted change disables the translation even when
a user disables it from the setting.

Manually triggering a translation from the context menu is one important
use case for users who do not want Chrome to suggest translation, but
need manual translation.

I quickly revert the last change, and will revisit later to remove the
menu only when the feature is disabled by PolicyList.

BUG=711217
==========

[Takashi Toyoshima, 2017-05-09 11:30:53]

toyoshim@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Takashi Toyoshima, 2017-05-09 11:31:06]

Can you take a look?

[lazyboy, 2017-05-09 16:35:39]

lgtm to submit this revert, but I'm curious about the q below.

https://codereview.chromium.org/2872813004/diff/1/chrome/browser/renderer_con...
File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right):

https://codereview.chromium.org/2872813004/diff/1/chrome/browser/renderer_con...
chrome/browser/renderer_context_menu/render_view_context_menu.cc:1207: //
feature is disabled by the PolicyList.
Are you referring to kTranslateEnabled policy?
Given https://bugs.chromium.org/p/chromium/issues/detail?id=711217#c10, do we
ever *not* want to show this menu item?
Let's continue that discussion in the bug. This revert sgtm.

[Takashi Toyoshima, 2017-05-10 01:35:27]

Yeah, according to the effort of crbug.com/656607, we are recommended to have a
PolicyList that can disable a chrome feature that makes network requests.

[Takashi Toyoshima, 2017-05-10 01:35:34]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2017-05-10 01:36:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 03:38:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 03:38:41]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has
not started yet; builder either lacks capacity or does not exist (misspelled?))
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[Takashi Toyoshima, 2017-05-10 04:24:09]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2017-05-10 04:24:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 05:34:55]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494390249276770, "parent_rev":
"488d6999c101d4a2a6b7cb3ad5b0336d7bb54069", "commit_rev":
"a942138fe716b963ce8247cdcbd3082e841fd19c"}

[commit-bot: I haz the power, 2017-05-10 05:35:09]

Description was changed from

==========
Revert a change of disabling translation from context menu temporarily

The translation should be disabled if the feature is disabled by
PolicyList, but the submitted change disables the translation even when
a user disables it from the setting.

Manually triggering a translation from the context menu is one important
use case for users who do not want Chrome to suggest translation, but
need manual translation.

I quickly revert the last change, and will revisit later to remove the
menu only when the feature is disabled by PolicyList.

BUG=711217
==========

to

==========
Revert a change of disabling translation from context menu temporarily

The translation should be disabled if the feature is disabled by
PolicyList, but the submitted change disables the translation even when
a user disables it from the setting.

Manually triggering a translation from the context menu is one important
use case for users who do not want Chrome to suggest translation, but
need manual translation.

I quickly revert the last change, and will revisit later to remove the
menu only when the feature is disabled by PolicyList.

BUG=711217

Review-Url: https://codereview.chromium.org/2872813004
Cr-Commit-Position: refs/heads/master@{#470479}
Committed:
https://chromium.googlesource.com/chromium/src/+/a942138fe716b963ce8247cdcbd3...
==========

[commit-bot: I haz the power, 2017-05-10 05:35:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a942138fe716b963ce8247cdcbd3...