Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2872763002: Change front end type inference algebra to match analyzer. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
Leaf, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change front end type inference algebra to match analyzer. This CL swaps the behavior of greatest and least closure in solveTypeConstraint. It also changes greatestClosure(?) to `dynamic` rather than `Object`. These changes bring front end type inference more closely into line with analyzer type inference. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/d34d4e545c990b7897231b6a9e128fd04952d86f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -24 lines) Patch
M pkg/front_end/lib/src/fasta/type_inference/type_schema_elimination.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/type_inference/type_schema_elimination_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/front_end/test/fasta/type_inference/type_schema_environment_test.dart View 5 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-08 21:00:07 UTC) #2
scheglov
lgtm
3 years, 7 months ago (2017-05-08 21:04:31 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-08 21:19:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d34d4e545c990b7897231b6a9e128fd04952d86f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698