pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart - Issue 2872763002: Change front end type inference algebra to match analyzer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart

Issue 2872763002: Change front end type inference algebra to match analyzer. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/front_end/lib/src/fasta/type_inference/type_schema_elimination.dart ('k') | pkg/front_end/test/fasta/type_inference/type_schema_elimination_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart

diff --git a/pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart b/pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart

index 89a7f01fedc2c46d0ccb77de95b2d56cfc0d6e08..9300e3ff25ef3b21abb1ba9131f3fdf1ff04c813 100644

--- a/pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart

+++ b/pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart

@@ -392,11 +392,11 @@ class TypeSchemaEnvironment extends TypeEnvironment {

// Otherwise take whatever bound has partial information, e.g. `Iterable<?>`

if (constraint.lower is! UnknownType) {

return grounded

- ? greatestClosure(coreTypes, constraint.lower)

+ ? leastClosure(coreTypes, constraint.lower)

: constraint.lower;

} else {

return grounded

- ? leastClosure(coreTypes, constraint.upper)

+ ? greatestClosure(coreTypes, constraint.upper)

: constraint.upper;

}