Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2872743003: Change AccountManagerHelper initialization

Created:
3 years, 7 months ago by bsazonov
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, sync-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change AccountManagerHelper initialization This CL changes AccountManagerHelper initialization to make sure that AccountManagerHelper.get always returns the same instance. Important pieces: 1. Add checks to initializeAccountManagerHelper and overrideAccountManagerHelperForTests to enforce the invariant. 2. Remove resetAccountManagerHelperForTests since it breaks the invariant. 3. Make sure that ProcessInitializationHandler.initializePreNative isn't called before overrideAccountManagerHelperForTests. BUG=698258

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -163 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryActivityTest.java View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PasswordViewingTypeTest.java View 3 chunks +3 lines, -9 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesBasicTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/signin/OAuth2TokenServiceIntegrationTest.java View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/signin/OAuth2TokenServiceTest.java View 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/signin/SigninHelperTest.java View 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/signin/SigninTest.java View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProviderTest.java View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/sync/ui/PassphraseActivityTest.java View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/test/ChromeBrowserTestRule.java View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/util/FeatureUtilitiesTest.java View 4 chunks +2 lines, -9 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/invalidation/InvalidationControllerTest.java View 4 chunks +7 lines, -9 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProviderUnitTest.java View 6 chunks +11 lines, -12 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeSigninUtils.java View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/signin/SigninTestUtil.java View 4 chunks +5 lines, -25 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/parameters/AddFakeAccountToAppParameter.java View 2 chunks +0 lines, -8 lines 0 comments Download
M components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java View 3 chunks +45 lines, -31 lines 0 comments Download
M components/signin/core/browser/android/java/src/org/chromium/components/signin/ChildAccountInfoFetcher.java View 1 chunk +1 line, -2 lines 0 comments Download
M components/signin/core/browser/android/javatests/src/org/chromium/components/signin/test/AccountManagerHelperTest.java View 2 chunks +2 lines, -10 lines 0 comments Download
M components/signin/core/browser/android/javatests/src/org/chromium/components/signin/test/util/FakeAccountManagerDelegate.java View 1 chunk +5 lines, -2 lines 0 comments Download
M components/sync/android/javatests/src/org/chromium/components/sync/AndroidSyncSettingsTest.java View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 46 (46 generated)
bsazonov
The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-09 18:02:47 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872743003/1
3 years, 7 months ago (2017-05-09 18:04:22 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-09 18:35:09 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/173968) linux_android_rel_ng on ...
3 years, 7 months ago (2017-05-09 18:35:10 UTC) #4
bsazonov
The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-17 08:27:59 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872743003/1
3 years, 7 months ago (2017-05-17 08:28:32 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-17 09:00:51 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/269961)
3 years, 7 months ago (2017-05-17 09:00:52 UTC) #8
bsazonov
Patchset #1 (id:1) has been deleted
3 years, 7 months ago (2017-05-17 09:48:15 UTC) #9
bsazonov
The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-17 09:48:40 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872743003/20001
3 years, 7 months ago (2017-05-17 09:49:02 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-17 10:48:41 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/296058)
3 years, 7 months ago (2017-05-17 10:48:42 UTC) #13
bsazonov
Patchset #1 (id:20001) has been deleted
3 years, 7 months ago (2017-05-17 11:30:33 UTC) #14
bsazonov
The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-17 11:30:50 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872743003/40001
3 years, 7 months ago (2017-05-17 11:31:05 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-17 13:04:35 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/180274)
3 years, 7 months ago (2017-05-17 13:04:36 UTC) #18
bsazonov
Patchset #1 (id:40001) has been deleted
3 years, 7 months ago (2017-05-22 13:23:46 UTC) #19
bsazonov
The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-22 13:24:11 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872743003/60001
3 years, 7 months ago (2017-05-22 13:24:23 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-22 15:33:31 UTC) #22
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/299540)
3 years, 7 months ago (2017-05-22 15:33:32 UTC) #23
bsazonov
Patchset #1 (id:60001) has been deleted
3 years, 7 months ago (2017-05-22 16:55:23 UTC) #24
bsazonov
The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-22 16:56:38 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872743003/80001
3 years, 7 months ago (2017-05-22 16:57:18 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-22 19:04:59 UTC) #27
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/299675)
3 years, 7 months ago (2017-05-22 19:05:00 UTC) #28
bsazonov
The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-23 13:47:58 UTC) #29
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872743003/100001
3 years, 7 months ago (2017-05-23 13:48:17 UTC) #30
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-23 14:53:02 UTC) #31
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/274839)
3 years, 7 months ago (2017-05-23 14:53:03 UTC) #32
bsazonov
Patchset #1 (id:80001) has been deleted
3 years, 7 months ago (2017-05-23 15:02:50 UTC) #33
bsazonov
Patchset #1 (id:100001) has been deleted
3 years, 7 months ago (2017-05-23 15:02:59 UTC) #34
bsazonov
The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-23 15:03:15 UTC) #35
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872743003/120001
3 years, 7 months ago (2017-05-23 15:03:35 UTC) #36
bsazonov
Patchset #1 (id:120001) has been deleted
3 years, 7 months ago (2017-05-23 16:00:04 UTC) #37
bsazonov
The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-23 16:00:11 UTC) #38
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872743003/140001
3 years, 7 months ago (2017-05-23 16:00:48 UTC) #39
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-23 18:26:09 UTC) #40
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/300696)
3 years, 7 months ago (2017-05-23 18:26:10 UTC) #41
bsazonov
The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-24 11:44:38 UTC) #42
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872743003/140001
3 years, 7 months ago (2017-05-24 11:45:01 UTC) #43
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-24 13:35:11 UTC) #44
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 7 months ago (2017-05-24 13:35:13 UTC) #45
bsazonov
3 years, 7 months ago (2017-05-24 14:04:19 UTC) #46 
Description was changed from

==========
Change AccountManagerHelper initialization

BUG=
==========

to

==========
Change AccountManagerHelper initialization

This CL changes AccountManagerHelper initialization to make sure that
AccountManagerHelper.get always returns the same instance. Important pieces:
1. Add checks to initializeAccountManagerHelper and
   overrideAccountManagerHelperForTests to enforce the invariant.
2. Remove resetAccountManagerHelperForTests since it breaks the invariant.
3. Make sure that ProcessInitializationHandler.initializePreNative isn't called
   before overrideAccountManagerHelperForTests.

BUG=698258
==========

Powered by Google App Engine
This is Rietveld 408576698