Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp

Issue 2872723002: [DevTools] removed promise instrumentation from blink
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp
index fd86dcf86b5728d02721b5b517821b398e2bc00d..f2f57c620c0ade6e3e2ab2bb272cbc63b561b381 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp
@@ -6,7 +6,6 @@
#include "core/dom/ExecutionContext.h"
#include "core/dom/TaskRunnerHelper.h"
-#include "core/probe/CoreProbes.h"
namespace blink {
@@ -22,7 +21,6 @@ ScriptPromiseResolver::ScriptPromiseResolver(ScriptState* script_state)
state_ = kDetached;
resolver_.Clear();
}
- probe::AsyncTaskScheduled(GetExecutionContext(), "Promise", this);
dgozman 2017/05/08 23:28:05 This also removes trace event.
}
void ScriptPromiseResolver::Suspend() {
@@ -42,7 +40,6 @@ void ScriptPromiseResolver::Detach() {
resolver_.Clear();
value_.Clear();
keep_alive_.Clear();
- probe::AsyncTaskCanceled(GetExecutionContext(), this);
}
void ScriptPromiseResolver::KeepAliveWhilePending() {
@@ -72,7 +69,6 @@ void ScriptPromiseResolver::ResolveOrRejectImmediately() {
DCHECK(!GetExecutionContext()->IsContextDestroyed());
DCHECK(!GetExecutionContext()->IsContextSuspended());
{
- probe::AsyncTask async_task(GetExecutionContext(), this);
if (state_ == kResolving) {
resolver_.Resolve(value_.NewLocal(script_state_->GetIsolate()));
} else {

Powered by Google App Engine
This is Rietveld 408576698