Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2872703004: Remove old Audit implementation (Closed)

Created:
3 years, 7 months ago by Raymond Toy
Modified:
3 years, 7 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove old Audit implementation The old Audit implementation is not used anywhere anymore except in two tests that tested the old implmentation. Remove these tests as well. BUG=704967 TEST=none Review-Url: https://codereview.chromium.org/2872703004 Cr-Commit-Position: refs/heads/master@{#471021} Committed: https://chromium.googlesource.com/chromium/src/+/f832a981cfc5f907f47f287c9d2eb9582c623744

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1014 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 chunk +0 lines, -1 line 1 comment Download
D third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js View 1 chunk +0 lines, -921 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/unit-tests/jstest-test.html View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/unit-tests/testharness-test.html View 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Raymond Toy
PTAL. Old Audit is gone. Long live new Audit!
3 years, 7 months ago (2017-05-09 16:27:19 UTC) #2
hongchan
lgtm https://codereview.chromium.org/2872703004/diff/1/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG File third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG (left): https://codereview.chromium.org/2872703004/diff/1/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG#oldcode26399 third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG:26399: -crbug.com/591099 webaudio/unit-tests/jstest-test.html [ Failure ] Can you explain ...
3 years, 7 months ago (2017-05-10 15:24:15 UTC) #3
Raymond Toy
On 2017/05/10 15:24:15, hongchan wrote: > lgtm > > https://codereview.chromium.org/2872703004/diff/1/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG > File > third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG > ...
3 years, 7 months ago (2017-05-10 16:00:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872703004/1
3 years, 7 months ago (2017-05-10 16:02:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450270)
3 years, 7 months ago (2017-05-10 17:48:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872703004/1
3 years, 7 months ago (2017-05-10 19:44:36 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450622)
3 years, 7 months ago (2017-05-10 21:18:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872703004/1
3 years, 7 months ago (2017-05-11 14:41:12 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451782)
3 years, 7 months ago (2017-05-11 15:38:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872703004/1
3 years, 7 months ago (2017-05-11 17:29:17 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 18:42:03 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f832a981cfc5f907f47f287c9d2e...

Powered by Google App Engine
This is Rietveld 408576698