Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2872663002:
Avoid DCHECK when installing a theme with non-opaque NTP bg color. (Closed)
|
Created:
3 years, 7 months ago by Evan Stade Modified:
3 years, 7 months ago CC:
chromium-reviews, tfarina Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAvoid DCHECK when installing a theme with non-opaque NTP bg color.
BUG=719064
Review-Url: https://codereview.chromium.org/2872663002
Cr-Commit-Position: refs/heads/master@{#470646}
Committed: https://chromium.googlesource.com/chromium/src/+/9cc6a14e716bf8f342329710bfd3d3944365d90c
Patch Set 1 #
Total comments: 2
Messages
Total messages: 17 (10 generated)
estade@chromium.org changed reviewers: + chrishtr@chromium.org, pkasting@chromium.org
The CQ bit was checked by estade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
LGTM Should this have a test? https://codereview.chromium.org/2872663002/diff/1/chrome/browser/ui/views/fra... File chrome/browser/ui/views/frame/contents_web_view.cc (right): https://codereview.chromium.org/2872663002/diff/1/chrome/browser/ui/views/fra... chrome/browser/ui/views/frame/contents_web_view.cc:68: SkColorGetA(ntp_background))); Seems like this SkColorGetA can just become SK_AlphaOPAQUE.
> Should this have a test? probably https://codereview.chromium.org/2872663002/diff/1/chrome/browser/ui/views/fra... File chrome/browser/ui/views/frame/contents_web_view.cc (right): https://codereview.chromium.org/2872663002/diff/1/chrome/browser/ui/views/fra... chrome/browser/ui/views/frame/contents_web_view.cc:68: SkColorGetA(ntp_background))); On 2017/05/08 23:11:14, Peter Kasting wrote: > Seems like this SkColorGetA can just become SK_AlphaOPAQUE. It could. I considered it. Which is more correct/readable? I dunno. I erred on the side of not having this line assume something about the previous line.
The CQ bit was checked by estade@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
The CQ bit was checked by estade@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494439258094010, "parent_rev":
"46083e3783e7a71d7eef4aeb5c5f6b3cc4c0338d", "commit_rev":
"9cc6a14e716bf8f342329710bfd3d3944365d90c"}
Message was sent while issue was closed.
Description was changed from ========== Avoid DCHECK when installing a theme with non-opaque NTP bg color. BUG=719064 ========== to ========== Avoid DCHECK when installing a theme with non-opaque NTP bg color. BUG=719064 Review-Url: https://codereview.chromium.org/2872663002 Cr-Commit-Position: refs/heads/master@{#470646} Committed: https://chromium.googlesource.com/chromium/src/+/9cc6a14e716bf8f342329710bfd3... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9cc6a14e716bf8f342329710bfd3... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
