Add translations for WebAPKs.

Add translations for WebAPKs.

This CL adds a new grd file for strings used by WebAPKs. 
This also adds empty translation files (xtb files) so that the grd file can be successfully
built even before real translations are available.

BUG=719626
Review-Url: https://codereview.chromium.org/2872643003
Cr-Commit-Position: refs/heads/master@{#470968}
Committed: https://chromium.googlesource.com/chromium/src/+/fcbbe5e2f0ce12ffb49afb840d3967a9a327f7e4

[Xi Han, 2017-05-08 18:24:56]

Description was changed from

==========
Add strings to webapks.

BUG=
==========

to

==========
Add strings to translate for webapks.

BUG=
==========

[Xi Han, 2017-05-08 18:31:06]

Description was changed from

==========
Add strings to translate for webapks.

BUG=
==========

to

==========
Add strings to translate for webapks.

BUG=719626
==========

[Xi Han, 2017-05-08 18:36:30]

Patchset #1 (id:1) has been deleted

[Xi Han, 2017-05-08 18:36:36]

Patchset #1 (id:20001) has been deleted

[Xi Han, 2017-05-08 18:42:44]

Description was changed from

==========
Add strings to translate for webapks.

BUG=719626
==========

to

==========
Add translations for WebAPKs.

This adds empty translation files (xtb files) so that the grd file can be
successfully
built even before real translations are available.

BUG=719626
==========

[Xi Han, 2017-05-08 18:43:41]

Description was changed from

==========
Add translations for WebAPKs.

This adds empty translation files (xtb files) so that the grd file can be
successfully
built even before real translations are available.

BUG=719626
==========

to

==========
Add translations for WebAPKs.

This CL adds new grd files for strings used by WebAPKs. 
This also adds empty translation files (xtb files) so that the grd file can be
successfully
built even before real translations are available.

BUG=719626
==========

[Xi Han, 2017-05-08 19:12:13]

hanxi@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[Xi Han, 2017-05-08 19:12:14]

Hi Peter, could you please take a look? Thanks!

[pkotwicz, 2017-05-09 21:51:00]

LGTM with nits

https://codereview.chromium.org/2872643003/diff/40001/chrome/android/webapk/s...
File chrome/android/webapk/strings/android_webapk_strings.grd (right):

https://codereview.chromium.org/2872643003/diff/40001/chrome/android/webapk/s...
chrome/android/webapk/strings/android_webapk_strings.grd:97: <message
name="IDS_CHOOSE_HOST_BROWSER_DIALOG_TITLE" desc="Title for the host browser
picker dialog, which is used to ask users to pick a browser to launch the WebAPK
to be installed. [CHAR-LIMIT=32]">
Nit: "the WebAPK to be installed" -> "the installed WebAPK"
The WebAPK is already installed, it will not be installed sometime in the future

https://codereview.chromium.org/2872643003/diff/40001/chrome/android/webapk/s...
chrome/android/webapk/strings/android_webapk_strings.grd:100: <message
name="IDS_CHOOSE_HOST_BROWSER" desc="Content for the host browser picker dialog,
which is used to ask users to pick a browser to launch the WebAPK to be
installed. [CHAR-LIMIT=32]">
Nit: "the WebAPK to be installed" -> "the installed WebAPK"
The WebAPK is already installed, it will not be installed sometime in the future

[Xi Han, 2017-05-10 13:38:21]

hanxi@chromium.org changed reviewers:
+ thakis@chromium.org

[Xi Han, 2017-05-10 13:38:22]

Hi Nico: could you please take a look? Thanks!

https://codereview.chromium.org/2872643003/diff/40001/chrome/android/webapk/s...
File chrome/android/webapk/strings/android_webapk_strings.grd (right):

https://codereview.chromium.org/2872643003/diff/40001/chrome/android/webapk/s...
chrome/android/webapk/strings/android_webapk_strings.grd:97: <message
name="IDS_CHOOSE_HOST_BROWSER_DIALOG_TITLE" desc="Title for the host browser
picker dialog, which is used to ask users to pick a browser to launch the WebAPK
to be installed. [CHAR-LIMIT=32]">
On 2017/05/09 21:51:00, pkotwicz wrote:
> Nit: "the WebAPK to be installed" -> "the installed WebAPK"
> The WebAPK is already installed, it will not be installed sometime in the
future

Thanks! I must take this dialog as the one shown in Play Store before
installation when I was writing the description:(

https://codereview.chromium.org/2872643003/diff/40001/chrome/android/webapk/s...
chrome/android/webapk/strings/android_webapk_strings.grd:100: <message
name="IDS_CHOOSE_HOST_BROWSER" desc="Content for the host browser picker dialog,
which is used to ask users to pick a browser to launch the WebAPK to be
installed. [CHAR-LIMIT=32]">
On 2017/05/09 21:51:00, pkotwicz wrote:
> Nit: "the WebAPK to be installed" -> "the installed WebAPK"
> The WebAPK is already installed, it will not be installed sometime in the
future

Done.

[Xi Han, 2017-05-10 13:38:46]

The CQ bit was checked by hanxi@chromium.org to run a CQ dry run

[Xi Han, 2017-05-10 13:39:13]

Description was changed from

==========
Add translations for WebAPKs.

This CL adds new grd files for strings used by WebAPKs. 
This also adds empty translation files (xtb files) so that the grd file can be
successfully
built even before real translations are available.

BUG=719626
==========

to

==========
Add translations for WebAPKs.

This CL adds a new grd file for strings used by WebAPKs. 
This also adds empty translation files (xtb files) so that the grd file can be
successfully
built even before real translations are available.

BUG=719626
==========

[commit-bot: I haz the power, 2017-05-10 13:39:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 15:08:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 15:08:09]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nico, 2017-05-10 15:10:06]

pyl lgtm

How much size will this add to the chrome apk once there are translations?

[Xi Han, 2017-05-10 18:56:07]

hanxi@chromium.org changed reviewers:
+ agrieve@chromium.org

[Xi Han, 2017-05-10 18:56:08]

That is a good question. Since the strings are only build to WebApk target, I
don't think they will have impact on Chrome.apk size.

+agrieve@.

[agrieve, 2017-05-10 19:13:56]

I think that's right. These shouldn't affect chrome's apk.

https://codereview.chromium.org/2872643003/diff/60001/chrome/android/webapk/s...
File chrome/android/webapk/strings/android_webapk_strings.grd (right):

https://codereview.chromium.org/2872643003/diff/60001/chrome/android/webapk/s...
chrome/android/webapk/strings/android_webapk_strings.grd:100: <message
name="IDS_CHOOSE_HOST_BROWSER" desc="Content for the host browser picker dialog,
which is used to ask users to pick a browser to launch the installed WebAPK.
[CHAR-LIMIT=32]">
Your english string is much longer than 32 characters :P

[Xi Han, 2017-05-10 20:19:53]

Thanks!

https://codereview.chromium.org/2872643003/diff/60001/chrome/android/webapk/s...
File chrome/android/webapk/strings/android_webapk_strings.grd (right):

https://codereview.chromium.org/2872643003/diff/60001/chrome/android/webapk/s...
chrome/android/webapk/strings/android_webapk_strings.grd:100: <message
name="IDS_CHOOSE_HOST_BROWSER" desc="Content for the host browser picker dialog,
which is used to ask users to pick a browser to launch the installed WebAPK.
[CHAR-LIMIT=32]">
On 2017/05/10 19:13:56, agrieve wrote:
> Your english string is much longer than 32 characters :P

Good catch! Remove the limits for now, and will add it back once we know how the
text impacts the dialog when it shows.

[Xi Han, 2017-05-10 20:21:39]

The CQ bit was checked by hanxi@chromium.org

[Xi Han, 2017-05-10 20:21:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2872643003/#ps80001
(title: "Remove the string limit.")

[commit-bot: I haz the power, 2017-05-10 20:22:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 21:05:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 21:05:42]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Xi Han, 2017-05-11 14:58:25]

The CQ bit was checked by hanxi@chromium.org

[commit-bot: I haz the power, 2017-05-11 14:59:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 16:00:39]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494514705211670,
"parent_rev": "4e0c9590a53bdd1969d3d6ae2c7cfd36c3b30096", "commit_rev":
"fcbbe5e2f0ce12ffb49afb840d3967a9a327f7e4"}

[commit-bot: I haz the power, 2017-05-11 16:00:53]

Description was changed from

==========
Add translations for WebAPKs.

This CL adds a new grd file for strings used by WebAPKs. 
This also adds empty translation files (xtb files) so that the grd file can be
successfully
built even before real translations are available.

BUG=719626
==========

to

==========
Add translations for WebAPKs.

This CL adds a new grd file for strings used by WebAPKs. 
This also adds empty translation files (xtb files) so that the grd file can be
successfully
built even before real translations are available.

BUG=719626

Review-Url: https://codereview.chromium.org/2872643003
Cr-Commit-Position: refs/heads/master@{#470968}
Committed:
https://chromium.googlesource.com/chromium/src/+/fcbbe5e2f0ce12ffb49afb840d39...
==========

[commit-bot: I haz the power, 2017-05-11 16:00:55]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/fcbbe5e2f0ce12ffb49afb840d39...