Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2872633002: [subresource_filter] Remove dead OnManageLinkClicked code path (Closed)

Created:
3 years, 7 months ago by Charlie Harrison
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[subresource_filter] Remove dead OnManageLinkClicked code path Now that the updated UI [1] on Mac has landed, this path is unused. [1]: https://codereview.chromium.org/2826233002/ BUG=689992 Review-Url: https://codereview.chromium.org/2872633002 Cr-Commit-Position: refs/heads/master@{#470016} Committed: https://chromium.googlesource.com/chromium/src/+/b081a87e2df7e28ae9cef236fa29357236f09d9e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M chrome/browser/ui/content_settings/content_setting_bubble_model.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Charlie Harrison
Shivani: I missed this in the review of your CL, PTAL?
3 years, 7 months ago (2017-05-08 15:08:47 UTC) #4
shivanisha
On 2017/05/08 at 15:08:47, csharrison wrote: > Shivani: I missed this in the review of ...
3 years, 7 months ago (2017-05-08 15:39:01 UTC) #5
Charlie Harrison
Thanks! bauerb: PTAL for OWNERS?
3 years, 7 months ago (2017-05-08 15:46:28 UTC) #7
Bernhard Bauer
lgtm
3 years, 7 months ago (2017-05-08 15:52:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872633002/1
3 years, 7 months ago (2017-05-08 16:32:59 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 16:45:10 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b081a87e2df7e28ae9cef236fa29...

Powered by Google App Engine
This is Rietveld 408576698