Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2872613003: Pass data objects directly to NativeEmitter (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -56 lines) Patch
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart View 3 chunks +7 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 12 chunks +27 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-09 11:39:10 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 7 months ago (2017-05-09 18:08:34 UTC) #3
Johnni Winther
3 years, 7 months ago (2017-05-10 07:23:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
37f86b324ecc18ad6b5fda23b2718e7b2d09aa5c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698