Pass data objects directly to NativeEmitter

pkg/compiler/lib/src/js_emitter/native_emitter.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.js_emitter.native_emitter;
 
 import '../common.dart';
-import '../compiler.dart' show Compiler;
+import '../common_elements.dart' show CommonElements;
 import '../elements/types.dart' show DartType, FunctionType;
 import '../elements/entities.dart';
 import '../js/js.dart' as jsAst;
 import '../js/js.dart' show js;
-import '../js_backend/js_backend.dart' show JavaScriptBackend, Namer;
 import '../js_backend/interceptor_data.dart';
 import '../js_backend/native_data.dart';
+import '../native/enqueue.dart' show NativeCodegenEnqueuer;
 import '../universe/world_builder.dart' show CodegenWorldBuilder;
+import '../world.dart' show ClosedWorld;
 
 import 'code_emitter_task.dart' show CodeEmitterTask;
 import 'model.dart';
 
 class NativeEmitter {
-  final CodeEmitterTask emitterTask;
-  final NativeData nativeData;
-  final InterceptorData interceptorData;
+  final CodeEmitterTask _emitterTask;
+  final ClosedWorld _closedWorld;
+  final CodegenWorldBuilder _worldBuilder;
+  final NativeCodegenEnqueuer _nativeCodegenEnqueuer;
 
   // Whether the application contains native classes.
   bool hasNativeClasses = false;
 
   // Caches the native subtypes of a native class.
   Map<ClassEntity, List<ClassEntity>> subtypes =
       <ClassEntity, List<ClassEntity>>{};
 
   // Caches the direct native subtypes of a native class.
   Map<ClassEntity, List<ClassEntity>> directSubtypes =
       <ClassEntity, List<ClassEntity>>{};
 
   // Caches the methods that have a native body.
   Set<FunctionEntity> nativeMethods = new Set<FunctionEntity>();
 
-  NativeEmitter(this.emitterTask, this.nativeData, this.interceptorData);
+  NativeEmitter(this._emitterTask, this._closedWorld, this._worldBuilder,
+      this._nativeCodegenEnqueuer);
 
-  Compiler get compiler => emitterTask.compiler;
-
-  JavaScriptBackend get backend => compiler.backend;
-
-  CodegenWorldBuilder get worldBuilder => compiler.codegenWorldBuilder;
-
-  Namer get namer => backend.namer;
+  CommonElements get _commonElements => _closedWorld.commonElements;
+  NativeData get _nativeData => _closedWorld.nativeData;
+  InterceptorData get _interceptorData => _closedWorld.interceptorData;
 
   /**
    * Prepares native classes for emission. Returns the unneeded classes.
    *
    * Removes trivial classes (that can be represented by a super type) and
    * generates properties that have to be added to classes (native or not).
    *
    * Updates the `nativeLeafTags`, `nativeNonLeafTags` and `nativeExtensions`
    * fields of the given classes. This data must be emitted with the
    * corresponding classes.
@@ skipping 29 matching lines @@
     // Compute a pre-order traversal of the subclass forest.  We actually want a
     // post-order traversal but it is easier to compute the pre-order and use it
     // in reverse.
     List<Class> preOrder = <Class>[];
     Set<Class> seen = new Set<Class>();
 
     Class objectClass = null;
     Class jsInterceptorClass = null;
 
     void walk(Class cls) {
-      if (cls.element == compiler.commonElements.objectClass) {
+      if (cls.element == _commonElements.objectClass) {
         objectClass = cls;
         return;
       }
-      if (cls.element == compiler.commonElements.jsInterceptorClass) {
+      if (cls.element == _commonElements.jsInterceptorClass) {
         jsInterceptorClass = cls;
         return;
       }
       if (seen.contains(cls)) return;
       seen.add(cls);
       walk(cls.superclass);
       preOrder.add(cls);
     }
 
     classes.forEach(walk);
@@ skipping 24 matching lines @@
         needed = true;
       } else if (interceptorClassesNeededByConstants.contains(classElement)) {
         needed = true;
       } else if (classesModifiedByEmitRTISupport.contains(classElement)) {
         // TODO(9556): Remove this test when [emitRuntimeTypeSupport] no longer
         // adds information to a class prototype or constructor.
         needed = true;
       } else if (extensionPoints.containsKey(cls)) {
         needed = true;
       }
-      if (nativeData.isJsInteropClass(classElement)) {
+      if (_nativeData.isJsInteropClass(classElement)) {
         needed = true; // TODO(jacobr): we don't need all interop classes.
       } else if (cls.isNative &&
-          nativeData.hasNativeTagsForcedNonLeaf(classElement)) {
+          _nativeData.hasNativeTagsForcedNonLeaf(classElement)) {
         needed = true;
         nonLeafClasses.add(cls);
       }
 
       if (needed || neededClasses.contains(cls)) {
         neededClasses.add(cls);
         neededClasses.add(cls.superclass);
         nonLeafClasses.add(cls.superclass);
       }
     }
 
     // Collect all the tags that map to each native class.
 
     Map<Class, Set<String>> leafTags = new Map<Class, Set<String>>();
     Map<Class, Set<String>> nonleafTags = new Map<Class, Set<String>>();
 
     for (Class cls in classes) {
       if (!cls.isNative) continue;
       ClassEntity element = cls.element;
-      if (nativeData.isJsInteropClass(element)) continue;
-      List<String> nativeTags = nativeData.getNativeTagsOfClass(cls.element);
+      if (_nativeData.isJsInteropClass(element)) continue;
+      List<String> nativeTags = _nativeData.getNativeTagsOfClass(cls.element);
 
       if (nonLeafClasses.contains(cls) || extensionPoints.containsKey(cls)) {
         nonleafTags
             .putIfAbsent(cls, () => new Set<String>())
             .addAll(nativeTags);
       } else {
         Class sufficingInterceptor = cls;
         while (!neededClasses.contains(sufficingInterceptor)) {
           sufficingInterceptor = sufficingInterceptor.superclass;
         }
@@ skipping 14 matching lines @@
         cls.nativeLeafTags = leafTags[cls].toList(growable: false);
       }
       if (nonleafTags[cls] != null) {
         cls.nativeNonLeafTags = nonleafTags[cls].toList(growable: false);
       }
       cls.nativeExtensions = extensionPoints[cls];
     }
 
     // Add properties containing the information needed to construct maps used
     // by getNativeInterceptor and custom elements.
-    if (backend.nativeCodegenEnqueuer.hasInstantiatedNativeClasses) {
+    if (_nativeCodegenEnqueuer.hasInstantiatedNativeClasses) {
       fillNativeInfo(jsInterceptorClass);
       for (Class cls in classes) {
         if (!cls.isNative || neededClasses.contains(cls)) {
           fillNativeInfo(cls);
         }
       }
     }
 
     // TODO(sra): Issue #13731- this is commented out as part of custom
     // element constructor work.
@@ skipping 42 matching lines @@
 
     return cls.methods.isEmpty &&
         cls.isChecks.isEmpty &&
         cls.callStubs.isEmpty &&
         !cls.superclass.isMixinApplication &&
         !cls.fields.any(needsAccessor);
   }
 
   void potentiallyConvertDartClosuresToJs(List<jsAst.Statement> statements,
       FunctionEntity member, List<jsAst.Parameter> stubParameters) {
-    FunctionEntity converter = compiler.commonElements.closureConverter;
+    FunctionEntity converter = _commonElements.closureConverter;
     jsAst.Expression closureConverter =
-        emitterTask.staticFunctionAccess(converter);
-    worldBuilder.forEachParameter(member, (DartType type, String name) {
+        _emitterTask.staticFunctionAccess(converter);
+    _worldBuilder.forEachParameter(member, (DartType type, String name) {
       // If [name] is not in [stubParameters], then the parameter is an optional
       // parameter that was not provided for this stub.
       for (jsAst.Parameter stubParameter in stubParameters) {
         if (stubParameter.name == name) {
           type = type.unaliased;
           if (type.isFunctionType) {
             // The parameter type is a function type either directly or through
             // typedef(s).
             FunctionType functionType = type;
             int arity = functionType.parameterTypes.length;
@@ skipping 25 matching lines @@
     List<jsAst.Statement> statements = <jsAst.Statement>[];
     potentiallyConvertDartClosuresToJs(statements, member, stubParameters);
 
     String target;
     jsAst.Expression receiver;
     List<jsAst.Expression> arguments;
 
     assert(invariant(member, nativeMethods.contains(member)));
     // When calling a JS method, we call it with the native name, and only the
     // arguments up until the last one provided.
-    target = nativeData.getFixedBackendName(member);
+    target = _nativeData.getFixedBackendName(member);
 
     if (isInterceptedMethod) {
       receiver = argumentsBuffer[0];
       arguments = argumentsBuffer.sublist(
           1, indexOfLastOptionalArgumentInParameters + 1);
     } else {
       // Native methods that are not intercepted must be static.
       assert(invariant(member, member.isStatic));
       arguments = argumentsBuffer.sublist(
           0, indexOfLastOptionalArgumentInParameters + 1);
-      if (nativeData.isJsInteropMember(member)) {
+      if (_nativeData.isJsInteropMember(member)) {
         // fixedBackendPath is allowed to have the form foo.bar.baz for
         // interop. This template is uncached to avoid possibly running out of
         // memory when Dart2Js is run in server mode. In reality the risk of
         // caching these templates causing an issue  is very low as each class
         // and library that uses typed JavaScript interop will create only 1
         // unique template.
         receiver = js
             .uncachedExpressionTemplate(
-                nativeData.getFixedBackendMethodPath(member))
+                _nativeData.getFixedBackendMethodPath(member))
             .instantiate([]);
       } else {
         receiver = js('this');
       }
     }
     statements
         .add(js.statement('return #.#(#)', [receiver, target, arguments]));
 
     return statements;
   }
 
   bool isSupertypeOfNativeClass(ClassEntity element) {
-    if (interceptorData.isMixedIntoInterceptedClass(element)) {
+    if (_interceptorData.isMixedIntoInterceptedClass(element)) {
       return true;
     }
 
     return subtypes[element] != null;
   }
 
   bool requiresNativeIsCheck(ClassEntity element) {
     // TODO(sra): Remove this function.  It determines if a native type may
     // satisfy a check against [element], in which case an interceptor must be
     // used.  We should also use an interceptor if the check can't be satisfied
     // by a native class in case we get a native instance that tries to spoof
     // the type info.  i.e the criteria for whether or not to use an interceptor
     // is whether the receiver can be native, not the type of the test.
     ClassEntity cls = element;
-    if (nativeData.isNativeOrExtendsNative(cls)) return true;
+    if (_nativeData.isNativeOrExtendsNative(cls)) return true;
     return isSupertypeOfNativeClass(element);
   }
 }