Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2872613002: Remove ENABLE(INSTANCE_COUNTER) code. (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ENABLE(INSTANCE_COUNTER) code. It's been unused for a while. (While this removes platform/wtf/InstanceCounter.h, platform/InstanceCounters.h remains.) BUG=675877 Review-Url: https://codereview.chromium.org/2872613002 Cr-Commit-Position: refs/heads/master@{#470027} Committed: https://chromium.googlesource.com/chromium/src/+/58541088774d456774a1aedb16b7b0038e129786

Patch Set 1 #

Patch Set 2 : gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -234 lines) Patch
M third_party/WebKit/Source/core/testing/Internals.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/platform/wtf/InstanceCounter.h View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/Source/platform/wtf/InstanceCounter.cpp View 1 chunk +0 lines, -155 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/RefCounted.h View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Nico
3 years, 7 months ago (2017-05-08 13:51:26 UTC) #3
haraken
LGTM
3 years, 7 months ago (2017-05-08 14:52:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872613002/20001
3 years, 7 months ago (2017-05-08 14:53:53 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 17:12:30 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/58541088774d456774a1aedb16b7...

Powered by Google App Engine
This is Rietveld 408576698