Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2872573003: Add UI for botlist to only display Machine Provider bots (Closed)

Created:
3 years, 7 months ago by kjlubick
Modified:
3 years, 7 months ago
Reviewers:
KevinL, stephana, smut
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Add UI for botlist to only display Machine Provider bots BUG=684951 Review-Url: https://codereview.chromium.org/2872573003 Committed: https://github.com/luci/luci-py/commit/5696c8ab3dec134e955a606bd552798f8fe8f8c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M appengine/swarming/ui/build/elements.html View 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-filters.html View 5 chunks +20 lines, -5 lines 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-list-data.html View 1 chunk +1 line, -0 lines 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-list-shared-behavior.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
kjlubick
https://screenshot.googleplex.com/1xcK183kq1f There are no MP bots on staging, but I can verify the API calls ...
3 years, 7 months ago (2017-05-08 14:13:32 UTC) #2
stephana
lgtm
3 years, 7 months ago (2017-05-08 14:47:17 UTC) #3
KevinL
lgtm
3 years, 7 months ago (2017-05-08 14:55:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872573003/1
3 years, 7 months ago (2017-05-08 14:55:07 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 14:59:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/5696c8ab3dec134e955a606bd552798f8fe8f8c1

Powered by Google App Engine
This is Rietveld 408576698