Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2872503005: [Mac] Fix for the Verbose State Text Color (Closed)

Created:
3 years, 7 months ago by spqchan
Modified:
3 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix for the Verbose State Text Color The text color should be white in incognito. BUG=709311 Review-Url: https://codereview.chromium.org/2872503005 Cr-Commit-Position: refs/heads/master@{#470198} Committed: https://chromium.googlesource.com/chromium/src/+/c4c5806ef59df14009ad9258ad98d231c5fe1699

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
spqchan
PTAL
3 years, 7 months ago (2017-05-09 01:19:53 UTC) #2
Avi (use Gerrit)
lgtm
3 years, 7 months ago (2017-05-09 01:48:37 UTC) #3
spqchan
On 2017/05/09 01:48:37, Avi (ping after 24h) wrote: > lgtm thanks!
3 years, 7 months ago (2017-05-09 01:50:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872503005/1
3 years, 7 months ago (2017-05-09 01:50:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/439056)
3 years, 7 months ago (2017-05-09 02:34:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872503005/1
3 years, 7 months ago (2017-05-09 04:10:16 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 04:21:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c4c5806ef59df14009ad9258ad98...

Powered by Google App Engine
This is Rietveld 408576698