Issue 2872483002: Split the NOT_STARTED and STOPPED_BEFORE_COMPLETION installability metrics.

Issue 2872483002: Split the NOT_STARTED and STOPPED_BEFORE_COMPLETION installability metrics. (Closed)

Created:
3 years, 7 months ago by dominickn

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

Split the NOT_STARTED and STOPPED_BEFORE_COMPLETION installability metrics. This CL ensures that the NOT_STARTED state is recorded separately from the STOPPED_BEFORE_COMPLETION state in the installability menu-open check metrics. BUG=704369 Review-Url: https://codereview.chromium.org/2844383004 Cr-Commit-Position: refs/heads/master@{#469283} (cherry picked from commit 07f715aee7d56fd113ac152d5e0b34dd1ece3ff6) Review-Url: https://codereview.chromium.org/2872483002 . Cr-Commit-Position: refs/branch-heads/3071@{#442} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/bdbec7de19e3eee6486e0f6607550c914e2f4083

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -27 lines)			Patch
M	chrome/browser/installable/installable_manager.cc	View	3 chunks	+20 lines, -14 lines	0 comments	Download
M	chrome/browser/installable/installable_manager_browsertest.cc	View	12 chunks	+17 lines, -12 lines	0 comments	Download
M	chrome/browser/installable/installable_metrics.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

dominickn

3 years, 7 months ago (2017-05-08 05:54:49 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bdbec7de19e3eee6486e0f6607550c914e2f4083.