Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2872463002:
LayoutTests: Disable flaky tests on Windows. (Closed)
DescriptionLayoutTests: Disable flaky tests on Windows.
These tests are failing a small amount of the time on the Windows Random
Order bots now they are running sharded on swarming. The tests affected
are;
* fast/css-grid-layout/grid-self-baseline-two-dimensional.html
* fast/css-grid-layout/grid-align-justify-stretch-with-orthogonal-flows.html
* fast/dnd/dropEffect-for-effectAllowed.html
* external/wpt/css/css-ui-3/outline-004.html
Bugs have been filed for each of the failing tests.
The most likely cause is that they depend on another test being run and
the sharding makes this no longer happening.
BUG=717347, 718717, 719298, 719299
NOTRY=true
Review-Url: https://codereview.chromium.org/2872463002
Cr-Commit-Position: refs/heads/master@{#469907}
Committed: https://chromium.googlesource.com/chromium/src/+/7f6264df1bd3a73c0f8af49adfc345126eebb1cd
Patch Set 1 #
Total comments: 2
Patch Set 2 : LayoutTests: Disable flaky tests on Windows. #Messages
Total messages: 17 (11 generated)
Description was changed from ========== LayoutTests: Disable flaky tests on Windows. These tests are failing a small amount of the time on the Windows Random Order bots now they are running sharded on swarming. The tests affected are; * fast/css-grid-layout/grid-self-baseline-two-dimensional.html * fast/css-grid-layout/grid-align-justify-stretch-with-orthogonal-flows.html * fast/dnd/dropEffect-for-effectAllowed.html * external/wpt/css/css-ui-3/outline-004.html Bugs have been filed for each of the failing tests. The most likely cause is that they depend on another test being run and the sharding makes this no longer happening. BUG=717347,718717,719298,719299 ========== to ========== LayoutTests: Disable flaky tests on Windows. These tests are failing a small amount of the time on the Windows Random Order bots now they are running sharded on swarming. The tests affected are; * fast/css-grid-layout/grid-self-baseline-two-dimensional.html * fast/css-grid-layout/grid-align-justify-stretch-with-orthogonal-flows.html * fast/dnd/dropEffect-for-effectAllowed.html * external/wpt/css/css-ui-3/outline-004.html Bugs have been filed for each of the failing tests. The most likely cause is that they depend on another test being run and the sharding makes this no longer happening. BUG=717347,718717,719298,719299 ==========
tansell@chromium.org changed reviewers: + mcgreevy@chromium.org
The CQ bit was checked by tansell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
tansell@chromium.org changed reviewers: + alancutter@chromium.org
Hi! These tests are failing on the Windows Random Order bots. Tim 'mithro' Ansell
rs lgtm.
mcgreevy@google.com changed reviewers: + mcgreevy@google.com
lgtm https://codereview.chromium.org/2872463002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2872463002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/TestExpectations:3360: # Layouts on Swarming (Windows) - https://crbug.com/717347 s/Layouts/LayoutTests/ ?
Description was changed from ========== LayoutTests: Disable flaky tests on Windows. These tests are failing a small amount of the time on the Windows Random Order bots now they are running sharded on swarming. The tests affected are; * fast/css-grid-layout/grid-self-baseline-two-dimensional.html * fast/css-grid-layout/grid-align-justify-stretch-with-orthogonal-flows.html * fast/dnd/dropEffect-for-effectAllowed.html * external/wpt/css/css-ui-3/outline-004.html Bugs have been filed for each of the failing tests. The most likely cause is that they depend on another test being run and the sharding makes this no longer happening. BUG=717347,718717,719298,719299 ========== to ========== LayoutTests: Disable flaky tests on Windows. These tests are failing a small amount of the time on the Windows Random Order bots now they are running sharded on swarming. The tests affected are; * fast/css-grid-layout/grid-self-baseline-two-dimensional.html * fast/css-grid-layout/grid-align-justify-stretch-with-orthogonal-flows.html * fast/dnd/dropEffect-for-effectAllowed.html * external/wpt/css/css-ui-3/outline-004.html Bugs have been filed for each of the failing tests. The most likely cause is that they depend on another test being run and the sharding makes this no longer happening. BUG=717347,718717,719298,719299 NOTRY=true ==========
https://codereview.chromium.org/2872463002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2872463002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/TestExpectations:3360: # Layouts on Swarming (Windows) - https://crbug.com/717347 On 2017/05/08 04:40:58, mcgreevy_g wrote: > s/Layouts/LayoutTests/ > > ? Done.
The CQ bit was checked by tansell@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mcgreevy@google.com, alancutter@chromium.org Link to the patchset: https://codereview.chromium.org/2872463002/#ps20001 (title: "LayoutTests: Disable flaky tests on Windows.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494218902118850,
"parent_rev": "e427c75396a3388f0b64915128a371bb1c5793f0", "commit_rev":
"7f6264df1bd3a73c0f8af49adfc345126eebb1cd"}
Message was sent while issue was closed.
Description was changed from ========== LayoutTests: Disable flaky tests on Windows. These tests are failing a small amount of the time on the Windows Random Order bots now they are running sharded on swarming. The tests affected are; * fast/css-grid-layout/grid-self-baseline-two-dimensional.html * fast/css-grid-layout/grid-align-justify-stretch-with-orthogonal-flows.html * fast/dnd/dropEffect-for-effectAllowed.html * external/wpt/css/css-ui-3/outline-004.html Bugs have been filed for each of the failing tests. The most likely cause is that they depend on another test being run and the sharding makes this no longer happening. BUG=717347,718717,719298,719299 NOTRY=true ========== to ========== LayoutTests: Disable flaky tests on Windows. These tests are failing a small amount of the time on the Windows Random Order bots now they are running sharded on swarming. The tests affected are; * fast/css-grid-layout/grid-self-baseline-two-dimensional.html * fast/css-grid-layout/grid-align-justify-stretch-with-orthogonal-flows.html * fast/dnd/dropEffect-for-effectAllowed.html * external/wpt/css/css-ui-3/outline-004.html Bugs have been filed for each of the failing tests. The most likely cause is that they depend on another test being run and the sharding makes this no longer happening. BUG=717347,718717,719298,719299 NOTRY=true Review-Url: https://codereview.chromium.org/2872463002 Cr-Commit-Position: refs/heads/master@{#469907} Committed: https://chromium.googlesource.com/chromium/src/+/7f6264df1bd3a73c0f8af49adfc3... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/7f6264df1bd3a73c0f8af49adfc3... |
