Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2872453003: gn: Document gen's --check flag. (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Document gen's --check flag. BUG=698539 Review-Url: https://codereview.chromium.org/2872453003 Cr-Commit-Position: refs/heads/master@{#470042} Committed: https://chromium.googlesource.com/chromium/src/+/25e109413ae504e8b7aaf942169fa70d28fde6ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M tools/gn/command_gen.cc View 3 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Nico
3 years, 7 months ago (2017-05-08 14:10:47 UTC) #3
brettw
lgtm
3 years, 7 months ago (2017-05-08 17:21:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872453003/1
3 years, 7 months ago (2017-05-08 17:46:32 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 17:53:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/25e109413ae504e8b7aaf942169f...

Powered by Google App Engine
This is Rietveld 408576698