Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2872453002: Worklet: Specify JavaScript MIME type for Worklets created from Blob URL (Closed)

Created:
3 years, 7 months ago by nhiroki
Modified:
3 years, 7 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Worklet: Specify JavaScript MIME type for Worklets created from Blob URL This is a preparation CL to switch Worklet from classic script loading to module loading. Worklet script (module script) must be served with one of the valid JavaScript MIME types[1]. This is required by the HTML spec[2]. This CL changes tests for PaintWorklet in order to obey the spec. [1] https://html.spec.whatwg.org/multipage/scripting.html#javascript-mime-type [2] https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-single-module-script (step 7) BUG=627945 Review-Url: https://codereview.chromium.org/2872453002 Cr-Commit-Position: refs/heads/master@{#469912} Committed: https://chromium.googlesource.com/chromium/src/+/9ed576b84a66830d0caf72c4e4823c9b821f6b3f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/csspaint/resources/test-runner-invalidation-logging.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/csspaint/resources/test-runner-paint-worklet.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/csspaint/valid-image-after-load.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/csspaint/valid-image-before-load.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
nhiroki
PTAL, thanks! (This is split from https://codereview.chromium.org/2826313003/)
3 years, 7 months ago (2017-05-08 03:35:12 UTC) #5
kouhei (in TOK)
lgtm
3 years, 7 months ago (2017-05-08 03:37:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872453002/1
3 years, 7 months ago (2017-05-08 03:47:11 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 07:13:07 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9ed576b84a66830d0caf72c4e482...

Powered by Google App Engine
This is Rietveld 408576698