Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Issue 2872443003: [heap] Make object field write atomic if concurrent marking is enabled. (Closed)

Created:
3 years, 7 months ago by ulan
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Make object field write atomic if concurrent marking is enabled. This patch also makes concurrent marking visitor loads atomic. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2872443003 Cr-Commit-Position: refs/heads/master@{#45179} Committed: https://chromium.googlesource.com/v8/v8/+/78082436025c1016aaf355251a0e4531487eaf87

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M src/heap/concurrent-marking.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ulan
ptal
3 years, 7 months ago (2017-05-08 11:07:07 UTC) #2
Michael Lippautz
lgtm
3 years, 7 months ago (2017-05-08 20:01:33 UTC) #3
Hannes Payer (out of office)
lgtm
3 years, 7 months ago (2017-05-08 20:08:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872443003/1
3 years, 7 months ago (2017-05-09 09:08:49 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 09:42:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/78082436025c1016aaf355251a0e4531487...

Powered by Google App Engine
This is Rietveld 408576698