more work aligning fasta.Token with analyzer.Token

pkg/front_end/lib/src/fasta/parser/parser.dart

Index: pkg/front_end/lib/src/fasta/parser/parser.dart
diff --git a/pkg/front_end/lib/src/fasta/parser/parser.dart b/pkg/front_end/lib/src/fasta/parser/parser.dart
index d3508fc81777fe6db1158e3f698a8d0d48a7d30d..0b1e47a0141fb88f4e511504997dbbe29410c864 100644
--- a/pkg/front_end/lib/src/fasta/parser/parser.dart
+++ b/pkg/front_end/lib/src/fasta/parser/parser.dart
@@ -1051,7 +1051,7 @@ class Parser {
       } else if (!optional("dynamic", token)) {
         reportRecoverableErrorCodeWithToken(token, codeBuiltInIdentifierAsType);
       }
-    } else if (!inPlainSync && token.isPseudo) {
+    } else if (!inPlainSync && token.type.isPseudo) {

[ahe, 2017/05/15 09:23:12]

Why this change?

[danrubel, 2017/05/15 13:03:18]

There was no corresponding `isPseudo` accessor in analyzer.Token and that
accessor always forwards to the type. Rather than add yet another accessor to
Token, I simply call `token.type.isPseudo`.  There are two other accessors in
analyzer.Token that do the same that I'd also like to remove, but I'll leave
that for another day.

All that said, if its important to have an `isPseudo` accessor on analyzer.Token
for performance or other reasons, then please let me know and I can add it and
refactor this call site to use it.

       if (optional('await', token)) {
         reportRecoverableErrorCode(token, codeAwaitAsIdentifier);
       } else if (optional('yield', token)) {