more work aligning fasta.Token with analyzer.Token

pkg/front_end/lib/src/fasta/parser/parser.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.parser.parser;
 
 import '../fasta_codes.dart'
     show
         FastaCode,
         FastaMessage,
@@ skipping 1033 matching lines @@
           reportUnrecoverableErrorCodeWithToken(token, codeExpectedIdentifier)
               .next;
     } else if (token.isBuiltInIdentifier &&
         !context.isBuiltInIdentifierAllowed) {
       if (context.inDeclaration) {
         reportRecoverableErrorCodeWithToken(
             token, codeBuiltInIdentifierInDeclaration);
       } else if (!optional("dynamic", token)) {
         reportRecoverableErrorCodeWithToken(token, codeBuiltInIdentifierAsType);
       }
-    } else if (!inPlainSync && token.isPseudo) {
+    } else if (!inPlainSync && token.type.isPseudo) {

[ahe, 2017/05/15 09:23:12]

Why this change?

[danrubel, 2017/05/15 13:03:18]

There was no corresponding `isPseudo` accessor in analyzer.Token and that
accessor always forwards to the type. Rather than add yet another accessor to
Token, I simply call `token.type.isPseudo`.  There are two other accessors in
analyzer.Token that do the same that I'd also like to remove, but I'll leave
that for another day.

All that said, if its important to have an `isPseudo` accessor on analyzer.Token
for performance or other reasons, then please let me know and I can add it and
refactor this call site to use it.

       if (optional('await', token)) {
         reportRecoverableErrorCode(token, codeAwaitAsIdentifier);
       } else if (optional('yield', token)) {
         reportRecoverableErrorCode(token, codeYieldAsIdentifier);
       } else if (optional('async', token)) {
         reportRecoverableErrorCode(token, codeAsyncAsIdentifier);
       }
     }
     listener.handleIdentifier(token, context);
     return token.next;
@@ skipping 2852 matching lines @@
     return reportUnrecoverableError(
         token, () => code.format(uri, token.charOffset, string));
   }
 }
 
 typedef FastaMessage NoArgument(Uri uri, int charOffset);
 
 typedef FastaMessage TokenArgument(Uri uri, int charOffset, Token token);
 
 typedef FastaMessage StringArgument(Uri uri, int charOffset, String string);