Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2872433004: [NetworkChangeNotifier] Get connection type from interface list for Windows (Closed)

Created:
3 years, 7 months ago by jkarlin
Modified:
3 years, 7 months ago
Reviewers:
pauljensen
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[NetworkChangeNotifier] Get connection type from interface list for Windows On Windows, use the NetworkInterfaceList to determine the connection type instead of returning UNKNOWN. This is essentially a reland of https://codereview.chromium.org/739983005 which was reverted because it was slow on XP, but now XP is no longer supported. The intent is to land this patch and monitor the canary dashboards to see if startup time increases. BUG=160537 Review-Url: https://codereview.chromium.org/2872433004 Cr-Commit-Position: refs/heads/master@{#470400} Committed: https://chromium.googlesource.com/chromium/src/+/013bc2a066a0d595098ad4b0a502b5732261b951

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M net/base/network_change_notifier.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/base/network_change_notifier.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M net/base/network_change_notifier_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
jkarlin
Paul: PTAL, thanks!
3 years, 7 months ago (2017-05-08 19:03:25 UTC) #7
pauljensen
lgtm
3 years, 7 months ago (2017-05-09 15:19:18 UTC) #8
jkarlin
Thanks, landing now and will follow the timings.
3 years, 7 months ago (2017-05-09 15:20:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872433004/1
3 years, 7 months ago (2017-05-09 15:20:35 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 19:05:22 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/013bc2a066a0d595098ad4b0a502...

Powered by Google App Engine
This is Rietveld 408576698